Extend Magic number checks for numeric strings #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Member
|
It would be great if we extend its unit test to support the new behavior. If you have time, we appreciate your support. You can open a new pull-request implementing it. |
lucasborin
approved these changes
Oct 1, 2020
Member
|
I changed the target branch to be the next version. We will enhance the changelog with it. |
lucasborin
added a commit
that referenced
this pull request
Oct 5, 2020
* fixes #156 * Update changelog.txt * Update changelog.txt * enabling log in exemption table * Update changelog.txt * Extend magic number check to find numbers in single quotes (#160) * Update changelog.txt * fixes #154 * Adding unit test to new magic number * Update changelog.txt * Update README.md (#162) * Update README.md (#163) * Update README.md (#164) Co-authored-by: Steffen <smb@users.noreply.github.com>
ghost
pushed a commit
that referenced
this pull request
Oct 16, 2020
* fixes #156 * Update changelog.txt * Update changelog.txt * enabling log in exemption table * Update changelog.txt * Extend magic number check to find numbers in single quotes (#160) * Update changelog.txt * fixes #154 * Adding unit test to new magic number * adding / removing all checks * Update changelog.txt * 1.05.0 * fixes #136 * Update changelog.txt * How to install via report * typo * allows run only once * execute the profile check only once * Update changelog.txt * Update changelog.txt * category decription update * Update changelog.txt * Update changelog.txt * reverting run only once * disabling coverages in test code (#166) * disabling coverages in test code * disabling apply on test code * &1 attributes reach threshold of &2 (#168) * %261 reach threshold of %262 * reach => reaching * minor fixes * Disabling "db access in ut" check when the OSQL/CDS UT framework is in use (#173) * fixes #171 * Update changelog.txt * Standardizing Messages (#174) * standardizing messages * reverting external_call_in_ut * Update changelog.txt * Raising profile message only once (#169) * raising the message only once * disabling referece to object * minor fix * Updating temporary branch * disabling coverages in test code (#166) * disabling coverages in test code * disabling apply on test code * &1 attributes reach threshold of &2 (#168) * %261 reach threshold of %262 * reach => reaching * minor fixes * Disabling "db access in ut" check when the OSQL/CDS UT framework is in use (#173) * fixes #171 * Update changelog.txt * Standardizing Messages (#174) * standardizing messages * reverting external_call_in_ut * Update changelog.txt * Update changelog.txt * Update changelog.txt * changing message text * check description Co-authored-by: Steffen <smb@users.noreply.github.com> Co-authored-by: Eugen Guenther <eugen.guenther@sap.com> Co-authored-by: Eugen Günther <64586309+eugen-guenther-sap@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #142
Had to put the entire regex in backticks to match single quotes.