Skip to content

Conversation

@lucasborin
Copy link
Member

No description provided.

@lucasborin lucasborin requested a review from a user October 7, 2020 20:07
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@lucasborin
Copy link
Member Author

@eugen-guenther-sap: Could you please check it again?

@ghost ghost merged commit afa5944 into 1.05.0 Oct 9, 2020
@ghost ghost deleted the disabling-coverage-in-ut-code branch October 9, 2020 06:17
lucasborin added a commit that referenced this pull request Oct 15, 2020
* disabling coverages in test code (#166)

* disabling coverages in test code

* disabling apply on test code

* &1 attributes reach threshold of &2 (#168)

* %261 reach threshold of %262

* reach => reaching

* minor fixes

* Disabling "db access in ut" check when the OSQL/CDS UT framework is in use (#173)

* fixes #171

* Update changelog.txt

* Standardizing Messages (#174)

* standardizing messages

* reverting external_call_in_ut

* Update changelog.txt
lucasborin added a commit that referenced this pull request Oct 16, 2020
* raising the message only once

* disabling referece to object

* minor fix

* Updating temporary branch

* disabling coverages in test code (#166)

* disabling coverages in test code

* disabling apply on test code

* &1 attributes reach threshold of &2 (#168)

* %261 reach threshold of %262

* reach => reaching

* minor fixes

* Disabling "db access in ut" check when the OSQL/CDS UT framework is in use (#173)

* fixes #171

* Update changelog.txt

* Standardizing Messages (#174)

* standardizing messages

* reverting external_call_in_ut

* Update changelog.txt

* Update changelog.txt

* Update changelog.txt

* changing message text

* check description
ghost pushed a commit that referenced this pull request Oct 16, 2020
* fixes #156

* Update changelog.txt

* Update changelog.txt

* enabling log in exemption table

* Update changelog.txt

* Extend magic number check to find numbers in single quotes (#160)

* Update changelog.txt

* fixes #154

* Adding unit test to new magic number

* adding / removing all checks

* Update changelog.txt

* 1.05.0

* fixes #136

* Update changelog.txt

* How to install via report

* typo

* allows run only once

* execute the profile check only once

* Update changelog.txt

* Update changelog.txt

* category decription update

* Update changelog.txt

* Update changelog.txt

* reverting run only once

* disabling coverages in test code (#166)

* disabling coverages in test code

* disabling apply on test code

* &1 attributes reach threshold of &2 (#168)

* %261 reach threshold of %262

* reach => reaching

* minor fixes

* Disabling "db access in ut" check when the OSQL/CDS UT framework is in use (#173)

* fixes #171

* Update changelog.txt

* Standardizing Messages (#174)

* standardizing messages

* reverting external_call_in_ut

* Update changelog.txt

* Raising profile message only once (#169)

* raising the message only once

* disabling referece to object

* minor fix

* Updating temporary branch

* disabling coverages in test code (#166)

* disabling coverages in test code

* disabling apply on test code

* &1 attributes reach threshold of &2 (#168)

* %261 reach threshold of %262

* reach => reaching

* minor fixes

* Disabling "db access in ut" check when the OSQL/CDS UT framework is in use (#173)

* fixes #171

* Update changelog.txt

* Standardizing Messages (#174)

* standardizing messages

* reverting external_call_in_ut

* Update changelog.txt

* Update changelog.txt

* Update changelog.txt

* changing message text

* check description

Co-authored-by: Steffen <smb@users.noreply.github.com>
Co-authored-by: Eugen Guenther <eugen.guenther@sap.com>
Co-authored-by: Eugen Günther <64586309+eugen-guenther-sap@users.noreply.github.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants