Skip to content

Conversation

@mhaas
Copy link
Contributor

@mhaas mhaas commented Jul 2, 2020

No description provided.

karthik.muthuswamy@sap.com
francesco.alda@sap.com
evgeny.arnautov@sap.com
# Michael
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EvgenyArn This should be better!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this? And, is this a hash of the email address?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My question is more out of curiosity than a question :)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mhaas looks fancy, what is it? :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EvgenyArn In Travis, each repo has an associated public and private key pair. I can encrypt data with the public key, and Travis can decrypt it with the private key. This is also how credentials are handled for pypi upload and for the DAR service key used for the system tests :)

@mhaas
Copy link
Contributor Author

mhaas commented Jul 2, 2020

Screenshot 2020-07-02 at 10 14 26

System tests working fine on Windows.

karthik.muthuswamy@sap.com
francesco.alda@sap.com
evgeny.arnautov@sap.com
# Michael

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mhaas looks fancy, what is it? :)

@mhaas mhaas merged commit b014838 into master Jul 2, 2020
@mhaas mhaas deleted the feat/system-tests-on-windows branch July 2, 2020 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants