Skip to content

feat: switch to using Fundamental Styles repo #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 7, 2019
Merged

feat: switch to using Fundamental Styles repo #566

merged 6 commits into from
Jun 7, 2019

Conversation

@jbadan
Copy link
Contributor

@jbadan jbadan commented Jun 6, 2019

Description

Switch from fiori-fundamentals to fundamental styles.

fixes #issueid

@jbadan jbadan requested a review from a team June 6, 2019 20:16
@netlify
Copy link

netlify bot commented Jun 6, 2019 •
edited
Loading

Deploy preview for fundamental-react ready!

Built with commit 148384a

https://deploy-preview-566--fundamental-react.netlify.com

@hertweckhr1
Copy link
Contributor

hertweckhr1 commented Jun 7, 2019

It looks like the styling is getting tweaked a little bit for some pages:

  • placemet of *EN (right is local branch)
    image

  • color of alert (right is local branch)
    image

@jbadan
Copy link
Contributor Author

jbadan commented Jun 7, 2019

@hertweckhr1 These changes are bugs we should open in fundamental-styles. We have version 1.5.1 of fiori fundamentals on master, here is using 1.5.8. Something changed in between those versions that is causing problems:

Screen Shot 2019-06-07 at 8 49 09 AM

hertweckhr1
hertweckhr1 approved these changes Jun 7, 2019
View reviewed changes
Copy link
Contributor

@hertweckhr1 hertweckhr1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 all you're changes look good! (fundamental problems are separate issue)

bcullman
bcullman reviewed Jun 7, 2019
View reviewed changes
README.md Outdated
For an existing react application, follow the steps below:

1. Install Fundamental-react and Fiori Fundamentals.
1. Install Fundamental-react and Fundamental Styles.
Copy link
Contributor

@bcullman bcullman Jun 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Fundamental-react" vs "Fundamental Styles". not sure which is the right written style here, but they should be the same.

@jbadan
Copy link
Contributor Author

jbadan commented Jun 7, 2019

LocalizationEditor button alignment fix: SAP/fundamental-styles#35

bcullman
bcullman approved these changes Jun 7, 2019
View reviewed changes
Copy link
Contributor

@bcullman bcullman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. 🚢

@jbadan jbadan merged commit 66a7cec into master Jun 7, 2019
@jbadan jbadan deleted the chore/switch-styles branch June 7, 2019 17:36
This was referenced Jun 7, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@bcullman bcullman bcullman approved these changes

@hertweckhr1 hertweckhr1 hertweckhr1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jbadan @hertweckhr1 @bcullman