Skip to content

feat: switch to using Fundamental Styles repo #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 7, 2019
Merged

feat: switch to using Fundamental Styles repo #566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
153b139
switch to fundamental styles
jbadan Jun 6, 2019
7b7cd38
update snapshots for url to styles
jbadan Jun 6, 2019
6e24d88
switch to ~
jbadan Jun 6, 2019
0938bf1
update readme
jbadan Jun 7, 2019
7091f28
merge master
jbadan Jun 7, 2019
148384a
merge master
jbadan Jun 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/ISSUE_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@

### Versions
**fundamental-react:**
**fiori-fundamentals:**
**fundamental-styles:**

---

_**NOTE:** Where applicable, please include uncropped screen captures._

_**DISCLAIMER:**
After triaging an issue, the fundamental-react team will see if it can be reproduced or confirmed. If more information is needed, the fundamental-react team will contact the author. Any issues awaiting responses from the author for more than 7 days will be closed. The author can re-open the issue at a later time if they can present the requested information._
After triaging an issue, the fundamental-react team will see if it can be reproduced or confirmed. If more information is needed, the fundamental-react team will contact the author. Any issues awaiting responses from the author for more than 7 days will be closed. The author can re-open the issue at a later time if they can present the requested information._
16 changes: 8 additions & 8 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@

## Description

The `fundamental-react` library is a set of [React](https://reactjs.org/) components built using [SAP Fiori Fundamentals](https://sap.github.io/fundamental/).
The `fundamental-react` library is a set of [React](https://reactjs.org/) components built using [SAP Fundamental Styles](https://sap.github.io/fundamental-styles/).

The SAP Fiori Fundamentals library is a design system and HTML/CSS component library used to build modern product user experiences with the SAP look and feel.
The SAP Fundamental Styles library is a design system and HTML/CSS component library used to build modern product user experiences with the SAP look and feel.

## API Reference

Expand All @@ -25,16 +25,16 @@ You will need to install [Node and Node Package Manager](https://www.npmjs.com/g

For an existing react application, follow the steps below:

1. Install Fundamental-react and Fiori Fundamentals.
1. Install `fundamental-react` and `fundamental-styles`.

```
npm install fiori-fundamentals fundamental-react
npm install fundamental-styles fundamental-react
```

1. Load the fiori-fundamentals styles. If using create-react-app, this will be in `App.css`.
1. Load the `fundamental-styles` styles. If using create-react-app, this will be in `App.css`.

```scss
@import '~fiori-fundamentals/dist/fiori-fundamentals-ie11.min.css';
@import '~fundamental-styles/dist/fundamental-styles-ie11.min.css';
```

1. Import components as needed. See [Component Documentation](https://sap.github.io/fundamental-react/) for examples and API details.
Expand Down Expand Up @@ -74,5 +74,5 @@ This library is licensed under the Apache Software License, v. 2 except as noted

## Similar Projects

- [Angular implementation of SAP Fiori Fundamentals](https://github.com/SAP/fundamental-ngx)
- [Vue implementation of SAP Fiori Fundamentals](https://github.com/SAP/fundamental-vue)
- [Angular implementation of SAP Fundamental Styles](https://github.com/SAP/fundamental-ngx)
- [Vue implementation of SAP Fundamental Styles](https://github.com/SAP/fundamental-vue)
Loading