chore: Bump eslint-plugin-react from 7.11.1 to 7.14.0 #622

dependabot-preview · 2019-06-24T06:57:33Z

Bumps eslint-plugin-react from 7.11.1 to 7.14.0.

Release notes

Sourced from eslint-plugin-react's releases.

v7.14.0

Added

Add jsx-curly-newline rule (#1493[] @golopot)

Add support for nested destructuring to prop-types (#296[] #1422[] @golopot)

Add support for variables defined as props to prop-types and no-unused-prop-types (#442[] #833[] #1002[] #1116[] #1257[] #1764[] @golopot)

Add checkFragmentShorthand option to jsx-key (#2316[] @kaykayehnn)

Fixed

Fix no-did-mount-set-state and no-did-update-set-state to handle cDU and cDM defined as class properties (#1595[] @jaaberg)

Fix sort-prop-types cash when a shape PropType is defined in a variable (#1749[] @alexzherdev)

Fix no-unused-state false positive when using state of non-lifecycle method (#2274[] @golopot)

Fix static-property-placement false positive when accessing static property inside method (#2283[] @dmason30)

Fix prop-type detection for annotated props with default value (#2298[] @yannickcr)

Changed

Add ESLint 6.0.0 as valid peerDependency (@yannickcr)

Improve no-render-return-value performance (#2259[] @golopot)

Change jsx-sort-props to report errors only on the identifier (#2312[] @MrHen)

Change to warn only once if react version cannot be detected (#2276[] @ljharb)

Documentation improvements (#2263[] @dimitropoulos, #2262[] @ybiquitous, #2295[] @battaglr, #2302[] @Jason-Cooke, #2303[] @golopot)

Code refactoring (#2265[] #2267[] #2286[] #2294[] @golopot, @ljharb)

Tests improvements (#2304[] #1047[] @golopot, @yannickcr)

#296: #296
#442: #442
#833: #833
#1002: #1002
#1047: #1047
#1116: #1116
#1257: #1257
#1422: #1422
#1493: #1493
#1595: #1595
#1749: #1749
#1764: #1764
#2259: #2259
#2262: #2262
#2263: #2263
#2265: #2265
#2267: #2267
#2274: #2274
#2276: #2276
#2283: #2283
#2286: #2286
#2294: #2294
#2295: #2295
#2298: #2298
#2302: #2302
#2303: #2303
#2304: #2304
... (truncated)

Changelog

Sourced from eslint-plugin-react's changelog.

7.14.0 - 2019-06-23

Added

Add [jsx-curly-newline][] rule (#1493[] @golopot)

Add support for nested destructuring to [prop-types][] (#296[] #1422[] @golopot)

Add support for variables defined as props to [prop-types][] and [no-unused-prop-types][] (#442[] #833[] #1002[] #1116[] #1257[] #1764[] @golopot)

Add checkFragmentShorthand option to [jsx-key][] (#2316[] @kaykayehnn)

Fixed

Fix [no-did-mount-set-state][] and [no-did-update-set-state][] to handle cDU and cDM defined as class properties (#1595[] @jaaberg)

Fix [sort-prop-types][] cash when a shape PropType is defined in a variable (#1749[] @alexzherdev)

Fix [no-unused-state][] false positive when using state of non-lifecycle method (#2274[] @golopot)

Fix [static-property-placement][] false positive when accessing static property inside method (#2283[] @dmason30)

Fix [prop-type][] detection for annotated props with default value (#2298[] @yannickcr)

Changed

Add ESLint 6.0.0 as valid peerDependency (@yannickcr)

Improve [no-render-return-value][] performance (#2259[] @golopot)

Change [jsx-sort-props][] to report errors only on the identifier (#2312[] @MrHen)

Change to warn only once if react version cannot be detected (#2276[] @ljharb)

Documentation improvements (#2263[] @dimitropoulos, #2262[] @ybiquitous, #2295[] @battaglr, #2302[] @Jason-Cooke, #2303[] @golopot)

Code refactoring (#2265[] #2267[] #2286[] #2294[] @golopot, @ljharb)

Tests improvements (#2304[] #1047[] @golopot, @yannickcr)

#296: #296
#442: #442
#833: #833
#1002: #1002
#1047: #1047
#1116: #1116
#1257: #1257
#1422: #1422
#1493: #1493
#1595: #1595
#1749: #1749
#1764: #1764
#2259: #2259
#2262: #2262
#2263: #2263
#2265: #2265
#2267: #2267
#2274: #2274
#2276: #2276
#2283: #2283
#2286: #2286
#2294: #2294
#2295: #2295
#2298: #2298
#2302: #2302
... (truncated)

Commits

dfaa92f Update CHANGELOG and bump version
c52b61b Merge pull request #2316 from kaykayehnn/jsx-key-fragments
8db631b [Fix] Fix detection of annotated props with default value
bbebefd [Tests] Remove AppVeyor
0d49f5a [New] Add ESLint ^6.0.0 as valid peerDependency
0364ed2 Fix formatting issues
7c1abed Add checkFragmentShorthand option
ed04c2f Fix tests in eslint < 5
0d1aaf8 Handle fragments in jsx-key
7d449a9 [New] jsx-sort-props: Change reported range to only the identifier
Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
@dependabot use these labels will set the current labels as the default for future PRs for this repo and language
@dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
@dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
@dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
@dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

Update frequency (including time of day and day of week)
Automerge options (never/patch/minor, and dev/runtime dependencies)
Pull request limits (per update run and/or open at any time)
Out-of-range updates (receive only lockfile updates, if desired)
Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

Bumps [eslint-plugin-react](https://github.com/yannickcr/eslint-plugin-react) from 7.11.1 to 7.14.0. - [Release notes](https://github.com/yannickcr/eslint-plugin-react/releases) - [Changelog](https://github.com/yannickcr/eslint-plugin-react/blob/master/CHANGELOG.md) - [Commits](jsx-eslint/eslint-plugin-react@v7.11.1...v7.14.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

netlify · 2019-06-24T06:59:32Z

Deploy preview for fundamental-react ready!

Built with commit 6ab108d

https://deploy-preview-622--fundamental-react.netlify.com

jbadan

This "fix" Fix prop-type detection for annotated props with default value (#2298[] @yannickcr) was actually a breaking change. We will need to update our components proptypes.

Users/i869315/externals/fundamental-react/src/ActionBar/ActionBar.js
  8:37  error  'children' is missing in props validation  react/prop-types

/Users/i869315/externals/fundamental-react/src/Alert/Alert.js
  33:13  error  'children' is missing in props validation  react/prop-types

/Users/i869315/externals/fundamental-react/src/Badge/Badge.js
  7:34  error  'children' is missing in props validation  react/prop-types

/Users/i869315/externals/fundamental-react/src/Badge/Counter.js
  6:49  error  'children' is missing in props validation  react/prop-types

/Users/i869315/externals/fundamental-react/src/Badge/Label.js
  6:24  error  'children' is missing in props validation  react/prop-types

/Users/i869315/externals/fundamental-react/src/Badge/Status.js
  6:32  error  'children' is missing in props validation  react/prop-types

/Users/i869315/externals/fundamental-react/src/Breadcrumb/_BreadcrumbItem.js
  5:38  error  'className' is missing in props validation  react/prop-types
  5:49  error  'children' is missing in props validation   react/prop-types

/Users/i869315/externals/fundamental-react/src/Identifier/Identifier.js
  7:80  error  'children' is missing in props validation  react/prop-types

/Users/i869315/externals/fundamental-react/src/Menu/_MenuGroup.js
  6:29  error  'children' is missing in props validation  react/prop-types

/Users/i869315/externals/fundamental-react/src/Menu/_MenuItem.js
   5:52  error  'children' is missing in props validation                  react/prop-types
   5:62  error  'onclick' is missing in props validation                   react/prop-types
  26:26  error  'children.props' is missing in props validation            react/prop-types
  26:32  error  'children.props.className' is missing in props validation  react/prop-types

/Users/i869315/externals/fundamental-react/src/Menu/Menu.js
  8:30  error  'children' is missing in props validation  react/prop-types

/Users/i869315/externals/fundamental-react/src/Modal/Modal.js
  33:41  error  'children' is missing in props validation   react/prop-types
  33:67  error  'className' is missing in props validation  react/prop-types

/Users/i869315/externals/fundamental-react/src/Pagination/Pagination.js
  84:13  error  'displayTotalProps' is missing in props validation  react/prop-types

/Users/i869315/externals/fundamental-react/src/Panel/_PanelActions.js
  6:13  error  'children' is missing in props validation  react/prop-types

/Users/i869315/externals/fundamental-react/src/Panel/_PanelBody.js
  6:13  error  'children' is missing in props validation  react/prop-types

/Users/i869315/externals/fundamental-react/src/Panel/_PanelFilters.js
  6:13  error  'children' is missing in props validation  react/prop-types

/Users/i869315/externals/fundamental-react/src/Panel/_PanelFooter.js
  6:13  error  'children' is missing in props validation  react/prop-types

/Users/i869315/externals/fundamental-react/src/Panel/_PanelHeader.js
  6:13  error  'children' is missing in props validation  react/prop-types

/Users/i869315/externals/fundamental-react/src/Panel/Panel.js
  13:22  error  'children' is missing in props validation  react/prop-types

/Users/i869315/externals/fundamental-react/src/Panel/PanelGrid.js
  7:26  error  'children' is missing in props validation  react/prop-types

/Users/i869315/externals/fundamental-react/src/Tabs/TabGroup.js
  72:13  error  'tabGroupProps' is missing in props validation  react/prop-types

/Users/i869315/externals/fundamental-react/src/Tile/_TileContent.js
  7:20  error  'children' is missing in props validation     react/prop-types
  7:67  error  'productTile' is missing in props validation  react/prop-types

/Users/i869315/externals/fundamental-react/src/Tile/_TileMedia.js
  6:34  error  'productTile' is missing in props validation  react/prop-types

/Users/i869315/externals/fundamental-react/src/Tile/Tile.js
  17:9  error  'children' is missing in props validation  react/prop-types

/Users/i869315/externals/fundamental-react/src/TimePicker/_TimePickerItem.js
  212:52  error  'onClick' is missing in props validation  react/prop-types

/Users/i869315/externals/fundamental-react/src/Toggle/Toggle.js
  21:46  error  'children' is missing in props validation  react/prop-types

dependabot-preview · 2019-06-25T06:36:36Z

A newer version of eslint-plugin-react exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

hertweckhr1 · 2019-06-26T18:31:21Z

Added missing propTypes
deleted productTile from destructuring props in media Tile since not used and updated snapshots.

jbadan

🚢 @hertweckhr1 thank you for handling this!

…t-7.14.0

dependabot-preview bot added the dependencies Pull requests that update a dependency file label Jun 24, 2019

empty commit to rebuild netlify

f320678

jbadan requested changes Jun 24, 2019

View reviewed changes

hannah.van.seeters added 3 commits June 25, 2019 17:08

added missing proptypes

a29c1d1

added onclick proptype

28c5666

updated snapshot with deleted productTile in tile media

52383f3

hertweckhr1 requested a review from a team June 26, 2019 18:31

jbadan approved these changes Jun 27, 2019

View reviewed changes

Merge branch 'master' into dependabot/npm_and_yarn/eslint-plugin-reac…

6ab108d

…t-7.14.0

hertweckhr1 merged commit e4a5eb6 into master Jun 27, 2019

hertweckhr1 deleted the dependabot/npm_and_yarn/eslint-plugin-react-7.14.0 branch June 27, 2019 18:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: Bump eslint-plugin-react from 7.11.1 to 7.14.0 #622

chore: Bump eslint-plugin-react from 7.11.1 to 7.14.0 #622

Uh oh!

dependabot-preview bot commented Jun 24, 2019

Uh oh!

netlify bot commented Jun 24, 2019 •

edited

Loading

Uh oh!

jbadan left a comment

Uh oh!

dependabot-preview bot commented Jun 25, 2019

Uh oh!

hertweckhr1 commented Jun 26, 2019 •

edited

Loading

Uh oh!

jbadan left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chore: Bump eslint-plugin-react from 7.11.1 to 7.14.0 #622

chore: Bump eslint-plugin-react from 7.11.1 to 7.14.0 #622

Uh oh!

Conversation

dependabot-preview bot commented Jun 24, 2019

v7.14.0

Added

Fixed

Changed

7.14.0 - 2019-06-23

Added

Fixed

Changed

Uh oh!

netlify bot commented Jun 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jbadan left a comment

Choose a reason for hiding this comment

Uh oh!

dependabot-preview bot commented Jun 25, 2019

Uh oh!

hertweckhr1 commented Jun 26, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jbadan left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

netlify bot commented Jun 24, 2019 •

edited

Loading

hertweckhr1 commented Jun 26, 2019 •

edited

Loading