feat: work needed to bring in self contained styles #632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-react ready! Built with commit df93d02 |
bcullman
reviewed
Jun 27, 2019
.size-limit
Outdated
| path: "lib/index.js", | ||
| limit: "50 KB" | ||
| config: "config/webpack.config.sizeLimit.js", | ||
| limit: "550 KB" |
Contributor
Author
There was a problem hiding this comment.
did you read the description? 😈
50kb was gzipped, using the new custom webpack config I haven't been able to get it to return gzipped size to size-limit, so it is reporting the parsed size. While we're now at double the gzipped size (including the peer dependency weirdness).
We're really only 12kb larger than we were previously.
jbadan
commented
Jul 1, 2019
| } | ||
| ] | ||
| }, | ||
| externals: { |
greg-a-smith
reviewed
Jul 1, 2019
src/Button/Button.js
Outdated
| @@ -1,3 +1,4 @@ | |||
| import '../../node_modules/fundamental-styles/components/button.scss'; | |||
Contributor
There was a problem hiding this comment.
Does this need to include the ../../node_modules in the path or could the import be simplified to import 'fundamental-styles/components/button.scss';?
This was referenced Jul 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This will be a breaking change for consumers as they will need to update their webpack config as detailed in the updated readme.
This pr brings in the self-contained styles for Button, updates/simplifies the webpack configuration, updates jest config to allow for parsing scss.
Size-limit was not setup to handle scss files, I copied their internal config as much as possible with the addition of scss loaders. Caveat: the output now contains our peerDependencies (? I can't figure out why) and is reporting our parsed size, not gzipped
MASTER:
This PR (note - peer dependencies like react-dom and react and some devdeps for webpack are now being included on the node_modules side - I've attempted to troubleshoot this for a while, but I think at this point it's out of range of the spike and should be a followup):
Build:index works again! Thanks @greg-a-smith