fix: Datepicker triggers form submission when clicked on month, year & calendar icon buttons #852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Deploy preview for fundamental-react ready! Built with commit ee2053c |
Contributor
|
seems like the better fix would be to set the default |
jbadan
requested changes
Jan 22, 2020
Contributor
jbadan
left a comment
jbadan
left a comment
There was a problem hiding this comment.
Can you update the snapshots - npm run test -- -u
In order for the CLA Assistant to allow you to merge your changes, you'll need to add the email address you used to make the commits to your github account. You can see what email you used by running git config --list and looking at the user.email section. Let us know if you have any problems and thanks for your contribution!
Contributor
Author
|
I have pushed updated snapshots and also email address is set correctly for this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #850