Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/ActionBar/__snapshots__/ActionBar.test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ exports[`<ActionBar /> create basic Action Bar 1`] = `
>
<button
className="fd-button--light fd-button--compact sap-icon--nav-back"
type="button"
/>
</div>
<div
Expand Down Expand Up @@ -44,6 +45,7 @@ exports[`<ActionBar /> create basic Action Bar 2`] = `
>
<button
className="fd-button--light fd-button--compact sap-icon--nav-back"
type="button"
/>
</div>
<div
Expand Down
4 changes: 4 additions & 0 deletions src/Button/Button.js
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,10 @@ Button.propTypes = {
onClick: PropTypes.func
};

Button.defaultProps = {
typeAttr: 'button'
};

Button.propDescriptions = {
option: 'Indicates the importance of the button.',
selected: 'Set to **true** to set state of the button to "selected".',
Expand Down
7 changes: 7 additions & 0 deletions src/Button/__snapshots__/Button.test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
exports[`<Button /> create buttons 1`] = `
<button
className="fd-button"
type="button"
>
Regular Button
</button>
Expand All @@ -11,6 +12,7 @@ exports[`<Button /> create buttons 1`] = `
exports[`<Button /> create buttons 2`] = `
<button
className="fd-button--emphasized"
type="button"
>
Emphasized Button
</button>
Expand All @@ -19,6 +21,7 @@ exports[`<Button /> create buttons 2`] = `
exports[`<Button /> create buttons 3`] = `
<button
className="fd-button fd-button--positive"
type="button"
>
Positive Button
</button>
Expand All @@ -27,6 +30,7 @@ exports[`<Button /> create buttons 3`] = `
exports[`<Button /> create buttons 4`] = `
<button
className="fd-button sap-icon--cart"
type="button"
>
Icon Button
</button>
Expand All @@ -35,6 +39,7 @@ exports[`<Button /> create buttons 4`] = `
exports[`<Button /> create buttons 5`] = `
<button
className="fd-button fd-button--compact"
type="button"
>
Compact
</button>
Expand All @@ -44,6 +49,7 @@ exports[`<Button /> create buttons 6`] = `
<button
className="fd-button--emphasized is-selected"
selected={true}
type="button"
>
Selected State
</button>
Expand All @@ -53,6 +59,7 @@ exports[`<Button /> create buttons 7`] = `
<button
className="fd-button--emphasized is-disabled"
disabled={true}
type="button"
>
Disabled State
</button>
Expand Down
3 changes: 3 additions & 0 deletions src/Button/__snapshots__/ButtonGroup.test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,16 @@ exports[`<ButtonGroup /> create button group 1`] = `
>
<button
className="fd-button sap-icon--survey blue"
type="button"
/>
<button
className="fd-button sap-icon--pie-chart is-selected"
selected={true}
type="button"
/>
<button
className="fd-button sap-icon--pool"
type="button"
/>
</div>
`;
2 changes: 2 additions & 0 deletions src/ComboboxInput/__snapshots__/ComboboxInput.test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ exports[`<ComboboxInput /> create combobox input 1`] = `
>
<button
className="fd-button--light sap-icon--navigation-down-arrow fd-input-group__button"
type="button"
/>
</span>
</div>
Expand Down Expand Up @@ -65,6 +66,7 @@ exports[`<ComboboxInput /> create combobox input 2`] = `
>
<button
className="fd-button--light fd-button--compact sap-icon--navigation-down-arrow fd-input-group__button"
type="button"
/>
</span>
</div>
Expand Down
5 changes: 5 additions & 0 deletions src/Dropdown/__snapshots__/Dropdown.test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ exports[`<Dropdown /> create dropdown component 1`] = `
onKeyPress={[Function]}
role="button"
tabIndex={0}
type="button"
>
Select
</button>
Expand Down Expand Up @@ -57,6 +58,7 @@ exports[`<Dropdown /> create dropdown component 2`] = `
onKeyPress={[Function]}
role="button"
tabIndex={0}
type="button"
>
Select
</button>
Expand Down Expand Up @@ -90,6 +92,7 @@ exports[`<Dropdown /> create dropdown component 3`] = `
onKeyPress={[Function]}
role="button"
tabIndex={0}
type="button"
>
Select
</button>
Expand Down Expand Up @@ -124,6 +127,7 @@ exports[`<Dropdown /> create dropdown component 4`] = `
onKeyPress={[Function]}
role="button"
tabIndex={0}
type="button"
>
Select
</button>
Expand Down Expand Up @@ -159,6 +163,7 @@ exports[`<Dropdown /> create dropdown component 5`] = `
onKeyPress={[Function]}
role="button"
tabIndex={0}
type="button"
>
Select
</button>
Expand Down
2 changes: 2 additions & 0 deletions src/InputGroup/__snapshots__/InputGroup.test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,7 @@ exports[`<InputGroup /> create input group items 9`] = `
>
<button
className="fd-button--light fd-input-group__button"
type="button"
>
Button
</button>
Expand All @@ -179,6 +180,7 @@ exports[`<InputGroup /> create input group items 10`] = `
>
<button
className="fd-button--light fd-button--compact fd-input-group__button"
type="button"
>
Button
</button>
Expand Down
2 changes: 2 additions & 0 deletions src/InputGroup/__snapshots__/InputGroupAddon.test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ exports[`<InputGroupAddon /> create input group add-on items 2`] = `
>
<button
className="fd-button fd-input-group__button"
type="button"
>
Text Here
</button>
Expand All @@ -26,6 +27,7 @@ exports[`<InputGroupAddon /> create input group add-on items 3`] = `
>
<button
className="fd-button fd-button--compact fd-input-group__button"
type="button"
>
Text Here
</button>
Expand Down
2 changes: 2 additions & 0 deletions src/ListGroup/__snapshots__/ListGroup.test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ exports[`<ListGroup /> create list group 1`] = `
>
<button
className="fd-button fd-button--standard sap-icon--edit"
type="button"
/>
</span>
</li>
Expand All @@ -68,6 +69,7 @@ exports[`<ListGroup /> create list group 2`] = `
>
<button
className="fd-button fd-button--standard sap-icon--edit"
type="button"
/>
</span>
</li>
Expand Down
1 change: 1 addition & 0 deletions src/ListGroup/__snapshots__/ListGroupItem.test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ exports[`<ListGroupItem /> create list group item 1`] = `
>
<button
className="fd-button fd-button--standard sap-icon--edit"
type="button"
/>
</span>
</li>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ exports[`<ListGroupItemActions /> create list group item actions 1`] = `
>
<button
className="fd-button fd-button--standard sap-icon--edit"
type="button"
/>
</span>
`;
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ exports[`<LocalizationEditor /> create localization editor 1`] = `
>
<button
className="fd-button--light fd-input-group__button"
type="button"
>
EN*
</button>
Expand Down Expand Up @@ -81,6 +82,7 @@ exports[`<LocalizationEditor /> create localization editor 2`] = `
>
<button
className="fd-button--light fd-button--compact fd-input-group__button"
type="button"
>
EN*
</button>
Expand Down Expand Up @@ -125,6 +127,7 @@ exports[`<LocalizationEditor /> create localization editor 3`] = `
>
<button
className="fd-button--light fd-input-group__button"
type="button"
>
EN*
</button>
Expand Down
2 changes: 2 additions & 0 deletions src/Panel/__snapshots__/Panel.test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ exports[`<Panel /> create panels 1`] = `
>
<button
className="fd-button fd-button--compact sap-icon--add"
type="button"
>
Add New Button
</button>
Expand Down Expand Up @@ -80,6 +81,7 @@ exports[`<Panel /> create panels 2`] = `
>
<button
className="fd-button fd-button--compact sap-icon--add"
type="button"
>
Add New Button
</button>
Expand Down
1 change: 1 addition & 0 deletions src/Panel/__snapshots__/PanelActions.test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ exports[`<PanelActions /> create panel actions 1`] = `
>
<button
className="fd-button fd-button--compact sap-icon--add"
type="button"
>
Add New Button
</button>
Expand Down
1 change: 1 addition & 0 deletions src/Panel/__snapshots__/PanelHeader.test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ exports[`<PanelHeader /> create panels 1`] = `
>
<button
className="fd-button fd-button--compact sap-icon--add"
type="button"
>
Add New Button
</button>
Expand Down
3 changes: 3 additions & 0 deletions src/SearchInput/__snapshots__/SearchInput.test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ exports[`<SearchInput /> create SearchInput 1`] = `
<button
className="fd-button--light sap-icon--search fd-input-group__button"
onClick={[Function]}
type="button"
/>
</span>
</div>
Expand Down Expand Up @@ -75,6 +76,7 @@ exports[`<SearchInput /> create SearchInput 2`] = `
<button
className="fd-button--light sap-icon--search fd-input-group__button"
onClick={[Function]}
type="button"
/>
</span>
</div>
Expand Down Expand Up @@ -116,6 +118,7 @@ exports[`<SearchInput /> create SearchInput 3`] = `
<button
className="fd-button--light sap-icon--search fd-input-group__button"
onClick={[Function]}
type="button"
/>
</span>
</div>
Expand Down
Loading