Set SaveGENIEEventRecord as true be default cafmaker fcl #739
Conversation
…alse for data cafmaker
|
trigger build LArSoft/lar*@LARSOFT_SUITE_v09_90_00 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
jzettle
left a comment
jzettle
left a comment
There was a problem hiding this comment.
This sounds like a positive addition to me! I approve if this helps with getting the right systematics in place from the NuSystematics tools
|
As is known, I love this addition! But, I do have a question. How much does this increase the file sizes @jedori0228 ? Just wondering if we want to turn it on by default or have it as an option with a separate CAF that production requests could use. |
I forgot that I have a supporting document related to this PR: https://sbn-docdb.fnal.gov/cgi-bin/sso/ShowDocument?docid=36869 The increment in the file size was 0.5% (when compared to a CAF that has no weights). |
|
That seems pretty small given that CAFs are already smaller. Approved. |
|
trigger build |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
From SBNSoftware/sbncode#459, which is merged to develop, I added a feature to save GENIE event record to the CAFMaker output. Here I set the default value of a boolean,
SaveGENIEEventRecord, totrue; this is crucial to constantly adopt new cross-section systematics without re-running CAFMaker job. More importantly, we now stopped updating LarSoft/nusystematics but moved to NuSystematics/nusystematics, and there are some missing dials that we cannot currently evaluate fromlarbased jobs. We can add those once we have GENIE record saved together with StandarRecord.