-
Notifications
You must be signed in to change notification settings - Fork 54
Setting cafmaker.SaveGENIEEventRecord to true for MC CAFMaker #479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting cafmaker.SaveGENIEEventRecord to true for MC CAFMaker #479
Conversation
|
Thank you @jedori0228 !!! |
|
trigger build LArSoft/lar*@LARSOFT_SUITE_v09_90_00 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for c14:prof - ignored failure for unit_test -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
henrylay97
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure whether my review adds anything now but this looks good, thanks @jedori0228.
We don't yet have a data CAFMaker fcl but I imagine that is something we will have very soon so all of us should remember to ensure we make the required change.
|
Approved and passes the working CI. |
With SBNSoftware/sbncode#459, we now have ability to save GENIE event record to CAFs. This feature is turned on when having
SaveGENIEEventRecordtotruein the CAFMaker parameter. In icaruscode, we opened a PR to have this parameter true for default MC CAFMaker: SBNSoftware/icaruscode#739I'm trying to do the same in sbndcode here; but as a NON sbnd-expert, I am not sure if this is the correct fhicl to change, but looks like to be the one? Someone from SBND should chime in here and correct me if I'm wrong.. Also, do we have data version of this in SBND? We should make sure there we have this parameter
false.More details can be found in here: https://sbn-docdb.fnal.gov/cgi-bin/sso/ShowDocument?docid=36869