Skip to content

Conversation

@jedori0228
Copy link
Contributor

@jedori0228 jedori0228 commented Jul 5, 2024

With SBNSoftware/sbncode#459, we now have ability to save GENIE event record to CAFs. This feature is turned on when having SaveGENIEEventRecord to true in the CAFMaker parameter. In icaruscode, we opened a PR to have this parameter true for default MC CAFMaker: SBNSoftware/icaruscode#739
I'm trying to do the same in sbndcode here; but as a NON sbnd-expert, I am not sure if this is the correct fhicl to change, but looks like to be the one? Someone from SBND should chime in here and correct me if I'm wrong.. Also, do we have data version of this in SBND? We should make sure there we have this parameter false.
More details can be found in here: https://sbn-docdb.fnal.gov/cgi-bin/sso/ShowDocument?docid=36869

@jedori0228 jedori0228 requested review from henrylay97 and lynnt20 July 5, 2024 17:50
@lynnt20
Copy link
Contributor

lynnt20 commented Jul 5, 2024

Thank you @jedori0228 !!!

@bear-is-asleep
Copy link
Contributor

trigger build LArSoft/lar*@LARSOFT_SUITE_v09_90_00

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for c14:prof - ignored failure for unit_test -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

Copy link
Member

@henrylay97 henrylay97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure whether my review adds anything now but this looks good, thanks @jedori0228.

We don't yet have a data CAFMaker fcl but I imagine that is something we will have very soon so all of us should remember to ensure we make the required change.

@bear-is-asleep
Copy link
Contributor

Approved and passes the working CI.

@bear-is-asleep bear-is-asleep merged commit f55a60b into develop Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants