light yield fix for Run-2 - #917
Open
mvicenzi wants to merge 10 commits into
Open
Conversation
This was
linked to
issues
Jul 28, 2026
Open
PetrilloAtWork
approved these changes
Jul 28, 2026
PetrilloAtWork
left a comment
Member
There was a problem hiding this comment.
I left some minor comments.
This is a configuration-breaking change, and I mentioned a way not to make it so.
However, this PR is very well written and very well documented.
Co-authored-by: Gianluca Petrillo <petrillo@slac.stanford.edu>
Co-authored-by: Gianluca Petrillo <petrillo@slac.stanford.edu>
Member
Author
|
Thank you @PetrilloAtWork ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note : This is being opened against
feature/pmtsim_gainto showcase meaningful differences for review, but it should be rebased on the production branch once #892 is merged.This PR introduces two empirical/effective corrections that close the light model discrepancy for Run-2 by fixing both the signal shape and the overall PE normalization (see SBN-docdb-48157, SBN-docdb-48511).
Two corrections are introduced:
ApplyTailSuppression()applies a subtractive, causal correction to the final waveform. It tracks a running low-pass-filtered estimateQof the waveform (filter with time constantTau) — and subtractsEps x Qfrom each sample (clamped so the pulse cannot flip polarity).Espis a factor that controls the strenght of the correction. This removes the excess integrated charge in the tail while leaving the prompt peak essentially untouched.Distance-dependent photon survival probability: instead of a flat QE cut, each scintillation photon is now kept with probability
QE x S(d), whereS(d)is a function of the distance between the emission point of the photon and the PMT. It is configured via specifying distance bins viaDistanceSurvival.BinEdgesand the corresponding values withDistanceSurvival.Factors. It defaults to 1 outside the configured bin range.Both corrections are currenlty enabled and tuned ONLY for Run-2 data.
The tune for Run-3/4 is still being optimized.