Offline PMT Decoder - #423
Conversation
- add fcl for specifying boards to ignore - specify nominal waveform length - specify spectdc input, add to pmt decoder chain
Version v09_79_00
…to feature/lynnt_pmt_decoder
- fcl parameter `timing_type` to choose which timing subsystem to use for the event trigger time - add fcl configs for PTB inputs - remove unused variables - add debug verbosity levels - add the fragID offset as a fcl config - add check for # of channels in the fragment, should be protected if ch15 is missing
Version v09_83_01
tomjunk
left a comment
tomjunk
left a comment
There was a problem hiding this comment.
Looks good! We still have some old getByLabel calls in there instead of newer things, but the art team has not made any more noises about deprecating it. As long as it's tested, we should get this into a release.
|
trigger build LArSoft/lar*@LARSOFT_SUITE_v09_85_00 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase unit_test SBND on slf7 for c14:prof - ignored warnings for build -- details available through the CI dashboard 🚨 For more details about the failed phase, check the unit_test SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
found a bug, need to do one more commit before merge! |
OK! btw, all the CI warnings are obviously unrelated |
|
ok should be good now :) |
|
trigger build LArSoft/lar*@LARSOFT_SUITE_v09_85_00 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase unit_test SBND on slf7 for c14:prof - ignored warnings for build -- details available through the CI dashboard 🚨 For more details about the failed phase, check the unit_test SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
5 participants
Offline PMT Decoder that reads in
artdaq::Fragments from the CAEN 1730 Digitizers and outputsraw::OpDetWaveforms. This PR is not necessary for the production release.Main features:
raw::OpDetWaveformbased on other timing subsystems, such as SPEC TDC and PTB. In the case that the products for the SPEC TDC or the PTB do not exist, the timestamp that will be stored is the start of the waveform w.r.t. the CAEN timing reference system.There are more features that I'd like to add to the decoder, but wanted at least a working version of it available on
sbndcodewith the hope that we'll soon be looking at real PMT waveforms 😄. Such features include: