Skip to content

Add new functions in geometry helper - #441

Merged
fjnicolas merged 3 commits into
SBNSoftware:developfrom
yangtj207:feature/tjyang_geohelper
Mar 26, 2024
Merged

Add new functions in geometry helper#441
fjnicolas merged 3 commits into
SBNSoftware:developfrom
yangtj207:feature/tjyang_geohelper

Conversation

@yangtj207

Copy link
Copy Markdown
Contributor

Add a function to calculate the intersection point of two wires.
Add an analyzer module to analyzer channel ID data.

@yangtj207
yangtj207 requested a review from tomjunk March 23, 2024 16:29

@tomjunk tomjunk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll go ahead and approve this, but the person doing the merge should check PR 443 as well -- there are commits with the same comments and what looks like the same changes in that. Maybe the same branch was used for both PRs?

@fjnicolas

Copy link
Copy Markdown
Contributor

I'll go ahead and approve this, but the person doing the merge should check PR 443 as well -- there are commits with the same comments and what looks like the same changes in that. Maybe the same branch was used for both PRs?

thanks for the warning @tomjunk, looks like that's the case. I'll take it into account for the merging process.

@fjnicolas

Copy link
Copy Markdown
Contributor

trigger build

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@fjnicolas fjnicolas mentioned this pull request Mar 25, 2024
@FNALbuild

Copy link
Copy Markdown
Collaborator

❌ CI build for SBND Failed at phase unit_test SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the unit_test SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

❌ CI build for SBND Failed at phase unit_test SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the unit_test SBND phase logs

parent CI build details are available through the CI dashboard

@fjnicolas
fjnicolas merged commit 53c1ccd into SBNSoftware:develop Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants