Skip to content

CRT Offline - Ana - #501

Merged
bear-is-asleep merged 4 commits into
feature/hlay_crt_offline_prfrom
feature/hlay_crt_offline_ana
Sep 26, 2024
Merged

CRT Offline - Ana#501
bear-is-asleep merged 4 commits into
feature/hlay_crt_offline_prfrom
feature/hlay_crt_offline_ana

Conversation

@henrylay97

@henrylay97 henrylay97 commented Aug 28, 2024

Copy link
Copy Markdown
Member

Description

This is part of a set of PRs designed to integrate updates to the CRT reconstruction to run it on data. To split up the diffs into more easily reviewable chunks there are 5 PRs to a common base branch. Once these have all been merged I will make a single PR to develop containing the full set of updates. Note, only on the final PR should the CI be run!

This particular PR updates our standalone CRT analysis tree module in order to run it on data. Primarily:

  • Addition of new branches we discovered would be useful.
  • Addition of new branches for extra DAQ information we wanted to retain.
  • Inclusion of fcl toggle-able switches in order to allow us to ignore truth branches when running on data (will retain default behaviour for MC).
  • Tiny change to the calib version of the module in order to compile due to minimal object changes. Sungbin will later make more substantial changes to incorporate CRT data to the calib ntuples.

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • Linked any relevant issues under Developement
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer as additional reviewer.
  • Does this affect the standard workflow?

Relevant PR links (optional)

The final PR will rely on one in sbncode and one in sbnobj

Link(s) to docdb describing changes (optional)

CRT Data Reconstruction is detailed here: https://sbn-docdb.fnal.gov/cgi-bin/sso/ShowDocument?docid=36812

@henrylay97 henrylay97 added the crt Cosmic Ray Tagger label Aug 28, 2024
@henrylay97
henrylay97 requested a review from sungbinoh August 28, 2024 14:20
@henrylay97 henrylay97 self-assigned this Aug 28, 2024
@henrylay97
henrylay97 changed the base branch from develop to feature/hlay_crt_offline_pr August 28, 2024 14:35

@absolution1 absolution1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. Thanks Henry.

@bear-is-asleep

Copy link
Copy Markdown
Contributor

trigger build LArSoft/lar*@LARSOFT_SUITE_v09_91_02

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@bear-is-asleep
bear-is-asleep merged commit 073c84e into feature/hlay_crt_offline_pr Sep 26, 2024
@henrylay97 henrylay97 mentioned this pull request Sep 26, 2024
6 tasks
@henrylay97
henrylay97 deleted the feature/hlay_crt_offline_ana branch November 21, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

crt Cosmic Ray Tagger

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants