Skip to content

Filter to reject events with very high hit multiplicity (ported from ProtoDUNE)#536

Merged
bear-is-asleep merged 13 commits into
developfrom
dbrailsf_datafilter
Nov 5, 2024
Merged

Filter to reject events with very high hit multiplicity (ported from ProtoDUNE)#536
bear-is-asleep merged 13 commits into
developfrom
dbrailsf_datafilter

Conversation

@absolution1

@absolution1 absolution1 commented Oct 16, 2024

Copy link
Copy Markdown
Contributor

Description

Include a port of the ProtoDUNE hit filter to reject events with a very high hit multiplicity. In data, some events have a very large number of hits: these events demand a lot of memory/processing time and are unusable. The filter is connected up to the data workflow to reject such events after gaushit, saving on memory and processing time.

I have set the minimum number of hits per TPC to be 50,000. This can obviously be iterated on as the filter is deployed.

I've included an extra data processing fcl (reco1_data_storefilteredevents.fcl) that keeps the filtered events (but in a separate output file)

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • Linked any relevant issues under Developement
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
  • Does this affect the standard workflow?

@absolution1 absolution1 added the enhancement New feature or request label Oct 16, 2024
@absolution1
absolution1 marked this pull request as draft October 16, 2024 16:25
@absolution1
absolution1 marked this pull request as ready for review October 17, 2024 15:03
@bear-is-asleep

Copy link
Copy Markdown
Contributor

trigger build LArSoft/lar*@LARSOFT_SUITE_v09_93_01 SBNSoftware/sbnanaobj@bug/coackley_ciCafv09_91_02

@bear-is-asleep bear-is-asleep left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Do we want to do this for MC?

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@absolution1

Copy link
Copy Markdown
Contributor Author

Looks good! Do we want to do this for MC?

Sorry @bear-is-asleep I completely missed this.
I don't think we do, for now at least. The filter is to reduce the number of times we get stuck in a long processing with data. The filter is quite generous in terms of letting events through, so I think the data/MC bias should be small.

@FNALbuild

Copy link
Copy Markdown
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@bear-is-asleep

Copy link
Copy Markdown
Contributor

trigger build LArSoft/lar*@LARSOFT_SUITE_v09_93_01 SBNSoftware/sbnanaobj@bug/coackley_ciCafv09_91_02

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@bear-is-asleep

Copy link
Copy Markdown
Contributor

@absolution1 , can you resolve conflicts and update the branch to develop? There are some build errors which I think are attributed to not being on the develop branch.

@absolution1

Copy link
Copy Markdown
Contributor Author

@bear-is-asleep this is done.
@henrylay97 can you check that the CRT bits in reco1_data.fcl are still OK?

@henrylay97

Copy link
Copy Markdown
Member

YAY! 🥳 (CRT stuff is all good (services & producer))

@bear-is-asleep

Copy link
Copy Markdown
Contributor

trigger build LArSoft/lar*@LARSOFT_SUITE_v09_93_01 SBNSoftware/sbnanaobj@bug/coackley_ciCafv09_91_02

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@bear-is-asleep

Copy link
Copy Markdown
Contributor

Ready to merge

@bear-is-asleep
bear-is-asleep merged commit 866169c into develop Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants