WireCell Noise-Filtering Updates (Data + Simulation) by lynnt20 · Pull Request #539 · SBNSoftware/sbndcode

lynnt20 · 2024-10-16T23:26:42Z

Description

Update coherent noise-filtering and other bits for MC and data.

adjust coherent noise parameters (for signal protection)
update RC tail deconvolution time constant (from 1.1ms to 0.5ms), based on data
change number of expected ticks in data from 3415 -> 3427
add a main jsonnet for running noise-filtering only

Checklist

Added at least 1 label from available labels.
Assigned at least 1 reviewer under Reviewers,
Assigned all contributers including yourself under Assignees
[N/A] Linked any relevant issues under Developement
[N/A] Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
[N/A] Does this affect the standard workflow?

Link(s) to docdb describing changes (optional)

Noise filtering studies in docdb38535.

This reverts commit 2d1ba6e.

bear-is-asleep · 2024-11-01T13:59:16Z

trigger build LArSoft/lar*@LARSOFT_SUITE_v09_93_01 SBNSoftware/sbnanaobj@bug/coackley_ciCafv09_91_02

FNALbuild · 2024-11-01T14:10:37Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2024-11-01T14:12:07Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

… ticks

FNALbuild · 2024-11-01T14:26:46Z

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2024-11-01T14:38:14Z

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

weihythu

change RC time constant(s) in other jsonnet (simparams.jsonnet) to be consistent with NF RC constant

weihythu

Thank you!

lynnt20 · 2024-11-04T17:38:56Z

trigger build LArSoft/lar*@LARSOFT_SUITE_v09_93_01 SBNSoftware/sbnanaobj@bug/coackley_ciCafv09_91_02

bear-is-asleep · 2024-11-06T16:06:55Z

trigger build LArSoft/lar*@LARSOFT_SUITE_v09_93_01 SBNSoftware/sbnanaobj@bug/coackley_ciCafv09_91_02

FNALbuild · 2024-11-06T16:18:23Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2024-11-06T16:26:01Z

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2024-11-06T16:27:15Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

bear-is-asleep · 2025-01-14T23:33:48Z

trigger build LArSoft/lar*@LARSOFT_SUITE_v09_93_01 LArSoft/larreco@RachelCoackley:develop SBNSoftware/sbncode@v09_93_01_p01 SBNSoftware/sbndcode@v09_93_01_01

FNALbuild · 2025-01-14T23:47:07Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2025-01-14T23:50:03Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2025-01-14T23:55:31Z

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2025-01-15T00:07:36Z

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored failure for unit_test - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

RachelCoackley · 2025-01-15T09:41:25Z

trigger build RachelCoackley/larreco>larreco@v09_93_01rachel LArSoft/lar*@LARSOFT_SUITE_v09_93_01 SBNSoftware/sbncode@v09_93_01_p01 SBNSoftware/sbndcode@v09_93_01_01 SBNSoftware/sbnanaobj@bug/coackley_ciCafv09_91_02 SBNSoftware/sbndaq-artdaq-core@v1_10_02 SBNSoftware/sbnobj@v09_19_05

FNALbuild · 2025-01-15T09:52:51Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2025-01-15T09:54:27Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2025-01-15T10:01:55Z

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2025-01-15T10:07:21Z

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

RachelCoackley · 2025-01-16T11:05:12Z

trigger build RachelCoackley/larreco>larreco@v09_93_01rachel LArSoft/lar*@LARSOFT_SUITE_v09_93_01 SBNSoftware/sbncode@v09_93_01_p02 SBNSoftware/sbnanaobj@bug/coackley_ciCafv09_91_02 SBNSoftware/sbndaq-artdaq-core@v1_10_03 SBNSoftware/sbnobj@v09_19_05

FNALbuild · 2025-01-16T11:48:22Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2025-01-16T11:53:03Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2025-01-16T12:03:39Z

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2025-01-16T12:10:25Z

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored failure for unit_test - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

bear-is-asleep · 2025-01-16T18:55:23Z

trigger build RachelCoackley/larreco>larreco@v09_93_01rachel LArSoft/lar*@LARSOFT_SUITE_v09_93_01 SBNSoftware/sbncode@v09_93_01_p02 SBNSoftware/sbnanaobj@bug/coackley_ciCafv09_91_02 SBNSoftware/sbndaq-artdaq-core@v1_10_03 SBNSoftware/sbnobj@v09_19_05

FNALbuild · 2025-01-16T19:06:51Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2025-01-16T19:08:37Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2025-01-16T19:19:50Z

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2025-01-16T19:35:45Z

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

bear-is-asleep · 2025-01-16T20:48:46Z

Approved, CI passes and reference updates make sense given PR.

lynnt20 added 5 commits October 14, 2024 12:13

update RC response to 0.5 ms, add documentation on bad channels

cfc2cae

add noise filtering only jsonnet configuration

6fb6cef

update number of ticks

114a440

tune coherent noise filtering params

2d1ba6e

turn on coherent noise filtering for simulation

71a379c

lynnt20 added the tpc Time Projection Chamber label Oct 16, 2024

lynnt20 self-assigned this Oct 16, 2024

lynnt20 added 4 commits October 31, 2024 13:31

add section to make sure NF inherits the right number of ticks

8cf658d

correct grouping (was missing the last group by accident)

89a33fb

Revert "tune coherent noise filtering params"

d2c35ce

This reverts commit 2d1ba6e.

turn off coherent NF for simulation again

0e60a20

lynnt20 changed the title ~~WireCell Noise-Filtering Updates (Data + MC)~~ WireCell Noise-Filtering Updates (Data) Oct 31, 2024

lynnt20 requested review from ebelchio12 and weihythu October 31, 2024 18:44

lynnt20 marked this pull request as ready for review October 31, 2024 18:44

update params.jsonnet so simulation also inherits the right number of…

26d0da7

… ticks

weihythu reviewed Nov 1, 2024

View reviewed changes

lynnt20 added 2 commits November 1, 2024 12:45

update RC response value in simulation

f6d2f36

actually update RC response value in simulation

8642baf

weihythu approved these changes Nov 1, 2024

View reviewed changes

lynnt20 changed the title ~~WireCell Noise-Filtering Updates (Data)~~ WireCell Noise-Filtering Updates (Data + Simulation) Nov 7, 2024

lynnt20 added data features for data processing detsim Detector simulation labels Nov 7, 2024

bear-is-asleep mentioned this pull request Dec 16, 2024

Feature/lynnt wirecell data #568

Merged

3 tasks

Merge branch 'v09_93_01_01p01rc' into feature/lynnt_wirecell_data

f5e4aa6

Merge branch 'develop' into feature/lynnt_wirecell_data

8652cc9

Merge branch 'develop' into feature/lynnt_wirecell_data

e8bd8c3

lynnt20 mentioned this pull request Jan 20, 2025

PMT Decoder Updates: Timing Data Product + Timing CAEN addition + more #541

Merged

4 tasks

bear-is-asleep merged commit 5aa7ff7 into develop Jan 24, 2025

Uh oh!

Conversation

lynnt20 commented Oct 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Link(s) to docdb describing changes (optional)

Uh oh!

bear-is-asleep commented Nov 1, 2024

Uh oh!

FNALbuild commented Nov 1, 2024

Uh oh!

FNALbuild commented Nov 1, 2024

Uh oh!

FNALbuild commented Nov 1, 2024

Uh oh!

FNALbuild commented Nov 1, 2024

Uh oh!

weihythu left a comment

Choose a reason for hiding this comment

Uh oh!

weihythu left a comment

Choose a reason for hiding this comment

Uh oh!

lynnt20 commented Nov 4, 2024

Uh oh!

bear-is-asleep commented Nov 6, 2024

Uh oh!

FNALbuild commented Nov 6, 2024

Uh oh!

FNALbuild commented Nov 6, 2024

Uh oh!

FNALbuild commented Nov 6, 2024

Uh oh!

bear-is-asleep commented Jan 14, 2025

Uh oh!

FNALbuild commented Jan 14, 2025

Uh oh!

FNALbuild commented Jan 14, 2025

Uh oh!

FNALbuild commented Jan 14, 2025

Uh oh!

FNALbuild commented Jan 15, 2025

Uh oh!

RachelCoackley commented Jan 15, 2025

Uh oh!

FNALbuild commented Jan 15, 2025

Uh oh!

FNALbuild commented Jan 15, 2025

Uh oh!

FNALbuild commented Jan 15, 2025

Uh oh!

FNALbuild commented Jan 15, 2025

Uh oh!

RachelCoackley commented Jan 16, 2025

Uh oh!

FNALbuild commented Jan 16, 2025

Uh oh!

FNALbuild commented Jan 16, 2025

Uh oh!

FNALbuild commented Jan 16, 2025

Uh oh!

FNALbuild commented Jan 16, 2025

Uh oh!

bear-is-asleep commented Jan 16, 2025

Uh oh!

FNALbuild commented Jan 16, 2025

Uh oh!

FNALbuild commented Jan 16, 2025

Uh oh!

FNALbuild commented Jan 16, 2025

Uh oh!

FNALbuild commented Jan 16, 2025

Uh oh!

bear-is-asleep commented Jan 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

lynnt20 commented Oct 16, 2024 •

edited

Loading