Skip to content

Data TPC Signal Processing: use calibrated electronics response by default - #556

Merged
bear-is-asleep merged 2 commits into
developfrom
feature/lynnt_elecresp
Jan 24, 2025
Merged

Data TPC Signal Processing: use calibrated electronics response by default#556
bear-is-asleep merged 2 commits into
developfrom
feature/lynnt_elecresp

Conversation

@lynnt20

@lynnt20 lynnt20 commented Nov 8, 2024

Copy link
Copy Markdown
Contributor

Description

Turn on using the calibrated electronic response parameters for signal processing for default data processing.

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • [N/A] Linked any relevant issues under Developement
  • [N/A] Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
  • [N/A] Does this affect the standard workflow?

Link(s) to docdb describing changes (optional)

Validation plots at docdb38655.

@lynnt20 lynnt20 added tpc Time Projection Chamber data features for data processing labels Nov 8, 2024
@lynnt20 lynnt20 self-assigned this Nov 8, 2024
@lynnt20
lynnt20 marked this pull request as ready for review November 8, 2024 19:54
@lynnt20
lynnt20 requested review from linyan-w and mrmooney November 8, 2024 19:54
@RachelCoackley

Copy link
Copy Markdown
Contributor

@lynnt20 please would you be able to resolve the conflicts? Thanks!! :)

@RachelCoackley

Copy link
Copy Markdown
Contributor

trigger build RachelCoackley/larreco>larreco@v09_93_01rachel LArSoft/lar*@LARSOFT_SUITE_v09_93_01 SBNSoftware/sbncode@v09_93_01_p02 SBNSoftware/sbnanaobj@bug/coackley_ciCafv09_91_02 SBNSoftware/sbndaq-artdaq-core@v1_10_03 SBNSoftware/sbnobj@v09_19_05

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored failure for unit_test - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@RachelCoackley

Copy link
Copy Markdown
Contributor

@lynnt20 I've ran the CI on the PR, there are a few ci_test warnings for product size differences (and one for fhicl dump outputs), please can you check if these are as you expected? (the nucosmics_caf_quick_test_sbndcode and single_caf_quick_test_sbndcode warnings can be ignored) Thanks! :)

@lynnt20
lynnt20 force-pushed the feature/lynnt_elecresp branch from 9406511 to 64d70f3 Compare January 21, 2025 18:50
@bear-is-asleep

Copy link
Copy Markdown
Contributor

Approved

@bear-is-asleep
bear-is-asleep merged commit f0f9d96 into develop Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data features for data processing tpc Time Projection Chamber

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants