FilterChoppy_module.cc

[tomjunk]

Description

This PR adds a check to see if the size of the raw::RDTimeStamp collection is zero and skips the filter calculation if it is. It also switches the logic of what happens if there are no RDTimeStamps -- either because of an invalid handle or the collection size is zero. This PR sets the behavior in such cases to true and not false. The reason for that is so that runs with no TPC data, such as run 18044, which has CRT and PTB data only, can pass the choppy event filter. If there is no choppiness because there is no TPC data, then there is no need to reject the event.

Checklist

• Added at least 1 label from available labels.
• Assigned at least 1 reviewer under Reviewers,
• Assigned all contributers including yourself under Assignees

No CAF formats are changed, nor workflows. Just a bugfix.

Tested on

lar -c run_decoders_job.fcl data_EventBuilder2_p2_art2_run18044_1_strmUnknown_20241220T212454.root

which segfaults in the choppy event filter in sbndcode v09_93_01_01 without this PR.

I also tried the code in this PR with

lar -c run_decoders_job.fcl data_evb02_EventBuilder2_art1_run13966_1_20240618T205823.root

All events in that file are choppy, and the choppy filter correctly filtered them out.

Relevant PR links (optional)

No external PRs needed.

[wjdanswjddl]

thanks for the exception handling, looks good to me!

[RachelCoackley]

trigger build RachelCoackley/larreco>larreco@v09_93_01rachel LArSoft/lar*@LARSOFT_SUITE_v09_93_01 SBNSoftware/sbncode@v09_93_01_p01 SBNSoftware/sbndcode@v09_93_01_01 SBNSoftware/sbnanaobj@bug/coackley_ciCafv09_91_02 SBNSoftware/sbndaq-artdaq-core@v1_10_02 SBNSoftware/sbnobj@v09_19_05

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

[FNALbuild]

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

[FNALbuild]

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

[RachelCoackley]

This is failing at the build stage (log can be found here). Error is:

5324: /scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbndcode/sbndcode/Decoders/PTB/SBNDPTBDecoder_module.cc:202:50: error: 'class sbndaq::CTBFragment' has no member named 'PTBWord'; did you mean 'TSWord'?
5325:   202 |                 tstruct.prev_timestamp = ctbfrag.PTBWord(iword)->prevTS;
5326:       |                                                  ^~~~~~~
5327:       |                                                  TSWord
5328: /scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbndcode/sbndcode/Decoders/PTB/SBNDPTBDecoder_module.cc:203:64: error: 'const ptb::content::word::trigger_t' {aka 'const struct ptb::content::word::trigger_t'} has no member named 'gate_counter'
5329:   203 |                 tstruct.gate_counter = ctbfrag.Trigger(iword)->gate_counter;

I'll have a look at this, I can't see why the changes made would bring up these errors

[RachelCoackley]

(I'll run the CI locally and fix this, it isn't a problem with the PR)

[RachelCoackley]

I got a successful build here. There are just caf differences for nucosmics_caf_quick_test_sbndcode and single_caf_quick_test_sbndcode

[tomjunk]

Does this PR need any help to move forwards? The CI issue above seems to be related to the PTB decoder which is not changed by this PR. It looks like develop has moved ahead -- sometimes merging develop into a PR branch is "clean" and the history is easy to understand, and sometimes all the commits in develop get piled up in the PR conversation.

[bear-is-asleep]

trigger build SBNSoftware/sbncode@bugfix/hlay_mcs_invalid_read_pr LArSoft/lar*@LARSOFT_SUITE_v10_03_01 sbndaq-artdaq-core@v1_10_03

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

[FNALbuild]

❌ CI build for SBND Failed at phase _report_checkout SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the _report_checkout SBND phase logs

parent CI build details are available through the CI dashboard

[FNALbuild]

❌ CI build for SBND Failed at phase _report_checkout SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the _report_checkout SBND phase logs

parent CI build details are available through the CI dashboard

[FNALbuild]

❌ CI build for SBND Failed at phase _report_checkout SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the _report_checkout SBND phase logs

parent CI build details are available through the CI dashboard

[bear-is-asleep]

trigger build SBNSoftware/sbncode@bugfix/hlay_mcs_invalid_read_pr LArSoft/lar*@LARSOFT_SUITE_v10_03_01 SBNSoftware/sbndaq-artdaq-core@v1_10_03

[FNALbuild]

❌ CI build for SBND Failed at phase _report_checkout SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the _report_checkout SBND phase logs

parent CI build details are available through the CI dashboard

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

[FNALbuild]

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

[FNALbuild]

⚠️ CI build for SBND Succeeded with warning at phase build on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

parent CI build details are available through the CI dashboard

[bear-is-asleep]

trigger build SBNSoftware/sbncode@bugfix/hlay_mcs_invalid_read_pr LArSoft/lar*@LARSOFT_SUITE_v10_03_01 SBNSoftware/sbndaq-artdaq-core@v1_10_04

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

[FNALbuild]

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

[FNALbuild]

✔️ CI build for SBND Succeeded on slf7 for e26:prof -- details available through the CI dashboard

parent CI build details are available through the CI dashboard

[bear-is-asleep]

Approved