Skip to content

de-caplitalize Services and change the total tick count to 3427 for d… - #602

Merged
bear-is-asleep merged 2 commits into
developfrom
trj_evdfcl_jan21_2024
Jan 24, 2025
Merged

de-caplitalize Services and change the total tick count to 3427 for d…#602
bear-is-asleep merged 2 commits into
developfrom
trj_evdfcl_jan21_2024

Conversation

@tomjunk

@tomjunk tomjunk commented Jan 21, 2025

Copy link
Copy Markdown
Contributor

Description

this PR changes the default number of ticks to show for the raw digit display in the LArSoft event display from 3415 to 3427, as seen in recent data from run 17722, taken November 17. It also fixes a typo where the number of samples in evd_sbnd_data.fcl was in a block called "Services" when in fact it ought to be "services".

It does not affect the CAF data format, nor the standard workflow. Assigning Tingjun Yang as reviewer. No other PRs need to be merged.

This is a re-PR of PR #561, which had just a one-line change to the evd_sbnd_data.fcl config file, but which had conflicts merged over time that just made the git history very confusing. It was easier just to recreate the PR and close out PR #561

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • Linked any relevant issues under Developement
  • No: Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
  • No: Does this affect the standard workflow?

@bear-is-asleep

Copy link
Copy Markdown
Contributor

trigger build RachelCoackley/larreco>larreco@v09_93_01rachel LArSoft/lar*@LARSOFT_SUITE_v09_93_01 SBNSoftware/sbncode@v09_93_01_p02 SBNSoftware/sbnanaobj@bug/coackley_ciCafv09_91_02 SBNSoftware/sbndaq-artdaq-core@v1_10_03 SBNSoftware/sbnobj@v09_19_05

@bear-is-asleep bear-is-asleep left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously approved

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@bear-is-asleep

Copy link
Copy Markdown
Contributor

Approved - CI picks up some expected changes in CNN in CAFs

@bear-is-asleep
bear-is-asleep merged commit 88f214d into develop Jan 24, 2025
@tomjunk
tomjunk deleted the trj_evdfcl_jan21_2024 branch February 10, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants