Skip to content

fix simchannel label to make calohit tmatch work - #622

Merged
bear-is-asleep merged 7 commits into
developfrom
feature/munjung-calohit_tmatch
Feb 14, 2025
Merged

fix simchannel label to make calohit tmatch work#622
bear-is-asleep merged 7 commits into
developfrom
feature/munjung-calohit_tmatch

Conversation

@wjdanswjddl

@wjdanswjddl wjdanswjddl commented Feb 3, 2025

Copy link
Copy Markdown
Contributor

Description

SimChannelLabel was still configured as simdrift, which broke the calohit truth matching.
This PR updates it to the proper 2Dsim label, simtpc2d:simpleSC to fix this bug.
This doesn't affect the CAF workflow itself, but fixes a CAF bug for SBND specifically.

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • Linked any relevant issues under Developement
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
  • Does this affect the standard workflow?

Relevant PR links (optional)

Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?

Link(s) to docdb describing changes (optional)

Is there a docdb describing the issue this solves or the feature added?

@wjdanswjddl wjdanswjddl added the caf Common analysis framework label Feb 3, 2025
@wjdanswjddl wjdanswjddl self-assigned this Feb 3, 2025
@wjdanswjddl
wjdanswjddl requested a review from linyan-w February 3, 2025 17:52
@bear-is-asleep

Copy link
Copy Markdown
Contributor

@wjdanswjddl it looks like you may have an accidental commit in here -
filtermodule by select by metadata.

Comment thread sbndcode/Calibration/DQM/FilterEventID_module.cc Outdated
Comment thread sbndcode/Calibration/DQM/FilterEventID_module.cc Outdated
@wjdanswjddl

Copy link
Copy Markdown
Contributor Author

@bear-is-asleep fixed! sorry about that

@wjdanswjddl

Copy link
Copy Markdown
Contributor Author

trigger build SBNSoftware/sbncode@bugfix/hlay_mcs_invalid_read_pr LArSoft/lar*@LARSOFT_SUITE_v10_03_01 SBNSoftware/sbndaq-artdaq-core@v1_10_04

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@bear-is-asleep

Copy link
Copy Markdown
Contributor

trigger build SBNSoftware/sbncode@bugfix/hlay_mcs_invalid_read_pr LArSoft/lar*@LARSOFT_SUITE_v10_03_01 SBNSoftware/sbndaq-artdaq-core@v1_10_04 SBNSoftware/sbncode@v10_03_01

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@bear-is-asleep

Copy link
Copy Markdown
Contributor

Approved, changes are from sbncode develop

@bear-is-asleep
bear-is-asleep merged commit c6f911b into develop Feb 14, 2025
@kjplows kjplows moved this from Done to 2025 PRs in SBN software development Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

caf Common analysis framework

Projects

Status: 2025 PRs
Status: In tagged release

Development

Successfully merging this pull request may close these issues.

7 participants