Skip to content

Exclude CVN in the code and fcl files for now - #627

Merged
bear-is-asleep merged 15 commits into
SBNSoftware:developfrom
yangtj207:feature/tjyang_cvnfix
Feb 7, 2025
Merged

Exclude CVN in the code and fcl files for now#627
bear-is-asleep merged 15 commits into
SBNSoftware:developfrom
yangtj207:feature/tjyang_cvnfix

Conversation

@yangtj207

@yangtj207 yangtj207 commented Feb 5, 2025 •
edited by bear-is-asleep
Loading

Copy link
Copy Markdown
Contributor

Description

Exclude CVN in the code and fcl files for now.

Changes needed until lardnn issue is resolved - link

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • Linked any relevant issues under Developement
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
  • Does this affect the standard workflow?

Relevant PR links (optional)

Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?
No

Link(s) to docdb describing changes (optional)

Is there a docdb describing the issue this solves or the feature added?
No

knoepfel and others added 14 commits June 4, 2024 14:55
@knoepfel
Accommodate geometry-refactoring changes
77c3a5e
@knoepfel
Merge branch 'develop' into geom-separate
618ffe3
@jzennamo
fixing geo services
155024c
@bear-is-asleep
Merge pull request SBNSoftware#608 from SBNSoftware/feature/zennamo_F…
e1178e5 
…clFixesForv10

Fixing Fcls for the New Geometry Handling
@jzennamo
removing gallery from CI
1878601
@jzennamo
fixing my CI changes
3fed90c
@bear-is-asleep
Update test/ci/ci_tests.cfg
679a034
@jzennamo @bear-is-asleep
Update test/ci/ci_tests.cfg
5d63633 
Co-authored-by: Bear Carlson <bcarlson1@ufl.edu>
@jzennamo @bear-is-asleep
Update test/ci/ci_tests.cfg
cacc7be 
Co-authored-by: Bear Carlson <bcarlson1@ufl.edu>
@bear-is-asleep
Merge branch 'feature/geom' into feature/zennamo_removeGalleryFromCI
97e2018
@bear-is-asleep
Merge pull request SBNSoftware#610 from SBNSoftware/feature/zennamo_r…
449d0ad 
…emoveGalleryFromCI

Removing Gallery From CI
@bear-is-asleep
Merge branch 'develop' into feature/geom
71e06d8
@yangtj207
Merge remote-tracking branch 'upstream/feature/geom' into feature/tjy…
1c310c8 
…ang_cvnfix
@yangtj207
Exclude CVN for now until an issue in larrecodnn is resolved.
dcbc756
@yangtj207 yangtj207 added the reco1/reco2 Reconstruction label Feb 5, 2025
@yangtj207
yangtj207 requested a review from henrylay97 February 5, 2025 17:11
@yangtj207 yangtj207 self-assigned this Feb 5, 2025
@yangtj207
Revert "Merge remote-tracking branch 'upstream/feature/geom' into fea…
4b98180 
…ture/tjyang_cvnfix"

This reverts commit 1c310c8, reversing
changes made to d22406f.
henrylay97
henrylay97 approved these changes Feb 5, 2025
View reviewed changes

@henrylay97 henrylay97 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks sensible for now with a revert as soon as the larsoft level issue is fixed.

@yangtj207 yangtj207 changed the title Feature/tjyang cvnfix Exclude CVN in the code and fcl files for now Feb 6, 2025
@henrylay97 henrylay97 mentioned this pull request Feb 7, 2025
Closed
@bear-is-asleep
bear-is-asleep merged commit 1c6655c into SBNSoftware:develop Feb 7, 2025
@bear-is-asleep bear-is-asleep mentioned this pull request Feb 7, 2025
Closed
@kjplows kjplows moved this from Done to 2025 PRs in SBN software development Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henrylay97 henrylay97 henrylay97 approved these changes

Assignees

@yangtj207 yangtj207

Labels

reco1/reco2 Reconstruction

Projects

SBN software development
Status: 2025 PRs
SBND Analysis Workshop
Status: In tagged release

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@yangtj207 @henrylay97 @bear-is-asleep @kjplows @knoepfel @jzennamo