Geometry v10 by bear-is-asleep · Pull Request #631 · SBNSoftware/sbndcode

bear-is-asleep · 2025-02-10T16:11:00Z

Description

Originally based on PR #393, then PR #590 but opened up as a feature branch so people can contribute to this. Changes pursuant to larsoft v10 geometry refactoring.

Checklist

Added at least 1 label from available labels.
Assigned at least 1 reviewer under Reviewers,
Assigned all contributers including yourself under Assignees
Linked any relevant issues under Developement
Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
Does this affect the standard workflow?

Relevant PR links (optional)

Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?

Link(s) to docdb describing changes (optional)

Is there a docdb describing the issue this solves or the feature added?

…s' into develop

…eco' into develop

This reverts commit d13af61.

This reverts commit 557c0e1.

…om_for_reco' into develop" This reverts commit e03e14a, reversing changes made to 4ed4a94.

…l_updates' into develop" This reverts commit 4ed4a94, reversing changes made to d22406f.

Co-authored-by: Henry Lay <h.lay@sheffield.ac.uk>

bear-is-asleep · 2025-02-10T18:34:21Z

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_03_01 SBNSoftware/sbncode@feature/usher_fixcluster3dsegfault SBNSoftware/sbnanaobj@bug/coackley_ciCafv09_91_02 SBNSoftware/sbndaq-artdaq-core@v1_10_03

FNALbuild · 2025-02-10T18:45:55Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2025-02-10T18:47:34Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2025-02-10T18:54:51Z

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2025-02-10T19:08:30Z

❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

bear-is-asleep · 2025-02-10T19:17:16Z

Merging in develop to ignore the CVN (until larcv fix) #630 will repatch this.

bear-is-asleep · 2025-02-10T19:17:34Z

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_03_01 SBNSoftware/sbncode@feature/usher_fixcluster3dsegfault SBNSoftware/sbnanaobj@bug/coackley_ciCafv09_91_02 SBNSoftware/sbndaq-artdaq-core@v1_10_03

FNALbuild · 2025-02-10T19:29:01Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2025-02-10T19:34:25Z

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2025-02-10T19:38:19Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2025-02-10T19:58:43Z

❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

fjnicolas

Looks the same as #590

RachelCoackley · 2025-02-11T11:41:38Z

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_03_01 SBNSoftware/sbncode@feature/usher_fixcluster3dsegfault SBNSoftware/sbnanaobj@bug/coackley_ciCafv09_91_02 SBNSoftware/sbndaq-artdaq-core@v1_10_03

FNALbuild · 2025-02-11T11:53:11Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2025-02-11T12:02:27Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2025-02-11T12:02:42Z

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2025-02-11T12:23:25Z

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

bear-is-asleep · 2025-02-11T17:34:32Z

Approved!!!!

henrylay97 and others added 14 commits January 7, 2025 13:38

Allow tracks through CRT flat

ebd352f

Don't drop raw event headers in CRT-only data reco workflow

97ec8b2

Fix north wall reco problem

db36e31

Merge remote-tracking branch 'origin/feature/hlay_crt_data_fcl_update…

4ed4a94

…s' into develop

Merge remote-tracking branch 'origin/bugfix/hlay_crt_nwall_geom_for_r…

e03e14a

…eco' into develop

Merge remote-tracking branch 'origin/feature/geom' into develop

184614b

Remove unnecessary libs

557c0e1

Update versioning

d13af61

Revert "Update versioning"

e559d74

This reverts commit d13af61.

Revert "Remove unnecessary libs"

840df1b

This reverts commit 557c0e1.

Revert "Merge remote-tracking branch 'origin/bugfix/hlay_crt_nwall_ge…

e991ac7

…om_for_reco' into develop" This reverts commit e03e14a, reversing changes made to 4ed4a94.

Revert "Merge remote-tracking branch 'origin/feature/hlay_crt_data_fc…

fd66fdb

…l_updates' into develop" This reverts commit 4ed4a94, reversing changes made to d22406f.

Update sbndcode/CRT/CRTAuxDetInitializer_tool.cc

f26c27a

Co-authored-by: Henry Lay <h.lay@sheffield.ac.uk>

Update test/Geometry/test_geometry_sbnd.fcl

0ae9bda

Co-authored-by: Henry Lay <h.lay@sheffield.ac.uk>

bear-is-asleep assigned bear-is-asleep and jzennamo Feb 10, 2025

bear-is-asleep requested review from fjnicolas, henrylay97, jzennamo, tomjunk and yangtj207 February 10, 2025 18:26

bear-is-asleep assigned henrylay97 Feb 10, 2025

bear-is-asleep added the geometry Geometry related issue label Feb 10, 2025

bear-is-asleep changed the title ~~Feature/geom salvage~~ Geometry v10 Feb 10, 2025

bear-is-asleep mentioned this pull request Feb 10, 2025

[v10 release candidate] Geometry v10 #590

Closed

6 tasks

bear-is-asleep marked this pull request as ready for review February 10, 2025 19:04

Merge branch 'develop' into feature/geom_salvage

638137d

fjnicolas approved these changes Feb 10, 2025

View reviewed changes

henrylay97 approved these changes Feb 11, 2025

View reviewed changes

SBNSoftware deleted a comment from FNALbuild Feb 11, 2025

bear-is-asleep merged commit 6fa7cda into develop Feb 11, 2025

kjplows moved this from Done to 2025 PRs in SBN software development Jan 16, 2026

Uh oh!

Conversation

bear-is-asleep commented Feb 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Relevant PR links (optional)

Link(s) to docdb describing changes (optional)

Uh oh!

bear-is-asleep commented Feb 10, 2025

Uh oh!

FNALbuild commented Feb 10, 2025

Uh oh!

FNALbuild commented Feb 10, 2025

Uh oh!

FNALbuild commented Feb 10, 2025

Uh oh!

FNALbuild commented Feb 10, 2025

Uh oh!

bear-is-asleep commented Feb 10, 2025

Uh oh!

bear-is-asleep commented Feb 10, 2025

Uh oh!

FNALbuild commented Feb 10, 2025

Uh oh!

FNALbuild commented Feb 10, 2025

Uh oh!

FNALbuild commented Feb 10, 2025

Uh oh!

FNALbuild commented Feb 10, 2025

Uh oh!

fjnicolas left a comment

Choose a reason for hiding this comment

Uh oh!

RachelCoackley commented Feb 11, 2025

Uh oh!

FNALbuild commented Feb 11, 2025

Uh oh!

FNALbuild commented Feb 11, 2025

Uh oh!

FNALbuild commented Feb 11, 2025

Uh oh!

FNALbuild commented Feb 11, 2025

Uh oh!

bear-is-asleep commented Feb 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

bear-is-asleep commented Feb 10, 2025 •

edited

Loading