Skip to content

Reenable CVN - #636

Merged
bear-is-asleep merged 4 commits into
SBNSoftware:developfrom
yangtj207:feature/tjyang_cvnfix
Feb 19, 2025
Merged

Reenable CVN#636
bear-is-asleep merged 4 commits into
SBNSoftware:developfrom
yangtj207:feature/tjyang_cvnfix

Conversation

@yangtj207

Copy link
Copy Markdown
Contributor

Description

Reenable CVN after changes in larsoft v10_04_01.

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • Linked any relevant issues under Developement
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
  • Does this affect the standard workflow?

Relevant PR links (optional)

Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?
We need larsoft version >= v10_04_01.

Link(s) to docdb describing changes (optional)

Is there a docdb describing the issue this solves or the feature added?

@yangtj207 yangtj207 added the tpc Time Projection Chamber label Feb 13, 2025
@yangtj207 yangtj207 self-assigned this Feb 13, 2025
@yangtj207

Copy link
Copy Markdown
Contributor Author

This PR can only be merged after we move to larsoft v10_04_01.

@absolution1 absolution1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yangtj207
These changes look nice, simple, and mostly functionising some calls

@bear-is-asleep

Copy link
Copy Markdown
Contributor

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_04_01 SBNSoftware/sbndaq-artdaq-core@v1_10_04 SBNSoftware/sbncode@v10_04_01

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for SBND Succeeded on slf7 for e26:prof -- details available through the CI dashboard

parent CI build details are available through the CI dashboard

@bear-is-asleep

Copy link
Copy Markdown
Contributor

Approved

@bear-is-asleep
bear-is-asleep merged commit 0d69fd7 into SBNSoftware:develop Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tpc Time Projection Chamber

Projects

Status: In Develop

Development

Successfully merging this pull request may close these issues.

4 participants