Skip to content

TEMPORARY CHANGE: Disable vertex refinement in pandora - #659

Merged
bear-is-asleep merged 1 commit into
developfrom
dbrailfs_pandoradisablevertexrefinement_temporary
Feb 24, 2025
Merged

TEMPORARY CHANGE: Disable vertex refinement in pandora#659
bear-is-asleep merged 1 commit into
developfrom
dbrailfs_pandoradisablevertexrefinement_temporary

Conversation

@absolution1

Copy link
Copy Markdown
Contributor

Description

This PR disables the vertex refinement in SBND's pandora workflow. This is a temporary change while an upstream larcontent issue is resolved.
This PR will mean vertex positions are less precise, but otherwise should not impact the downstream reco.
Thanks @henrylay97 for helping to understand the disabling procedure.

Checklist

  • [x ] Added at least 1 label from available labels.
  • [x ] Assigned at least 1 reviewer under Reviewers,
  • [x ] Assigned all contributers including yourself under Assignees
  • Linked any relevant issues under Developement
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
  • Does this affect the standard workflow?

Relevant PR links (optional)

Link(s) to docdb describing changes (optional)

@absolution1 absolution1 added the reco1/reco2 Reconstruction label Feb 24, 2025
@absolution1 absolution1 self-assigned this Feb 24, 2025

@henrylay97 henrylay97 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep - the xml changes look good to me.

Let's make an sbndcode issue to remind us to get this added back in as soon as we can :)

@jzennamo jzennamo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with other v10_04_03 PRs and it works! Thanks @absolution1 !

@bear-is-asleep

Copy link
Copy Markdown
Contributor

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_04_03 SBNSoftware/sbndaq-artdaq-core@v1_10_04 SBNSoftware/sbncode@v10_04_03

@bear-is-asleep bear-is-asleep linked an issue Feb 24, 2025 that may be closed by this pull request
4 tasks
@bear-is-asleep

Copy link
Copy Markdown
Contributor

Yep - the xml changes look good to me.

Let's make an sbndcode issue to remind us to get this added back in as soon as we can :)

done and linked

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@bear-is-asleep

Copy link
Copy Markdown
Contributor

Approved, changes from cvn still in references.

@bear-is-asleep
bear-is-asleep merged commit 5766270 into develop Feb 24, 2025
@absolution1

Copy link
Copy Markdown
Contributor Author

Hi @bear-is-asleep @kjplows
This was successfully included in a release already, right?
I believe the upstream larsoft fix is now in place. If there's already a patch release with this temporary PR included, then I think we can start the reverting procedure.

@kjplows

kjplows commented Feb 27, 2025

Copy link
Copy Markdown
Contributor

Hi @absolution1 , that's right - the offending PR was reverted in larsoft v10_04_04 and a new sbncode release is being prepped right now. I agree the reverting procedure should go ahead as soon as the release is out (hopefully before this evening UK time)

@kjplows

kjplows commented Feb 27, 2025

Copy link
Copy Markdown
Contributor

Just to follow up - sbncode v10_04_04 is out so we're good to go about reverting this @bear-is-asleep . Thanks!

@absolution1

Copy link
Copy Markdown
Contributor Author

I've issued the revert PR: #670

@kjplows kjplows moved this from Done to 2025 PRs in SBN software development Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reco1/reco2 Reconstruction

Projects

Status: 2025 PRs

Development

Successfully merging this pull request may close these issues.

TEMPORARY ISSUE: Vertex Refinement is disabled until a Larsoft PR is in

6 participants