TEMPORARY CHANGE: Disable vertex refinement in pandora - #659
Conversation
…am issue is fixed.
henrylay97
left a comment
There was a problem hiding this comment.
Yep - the xml changes look good to me.
Let's make an sbndcode issue to remind us to get this added back in as soon as we can :)
jzennamo
left a comment
There was a problem hiding this comment.
tested with other v10_04_03 PRs and it works! Thanks @absolution1 !
|
trigger build LArSoft/lar*@LARSOFT_SUITE_v10_04_03 SBNSoftware/sbndaq-artdaq-core@v1_10_04 SBNSoftware/sbncode@v10_04_03 |
done and linked |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
Approved, changes from cvn still in references. |
|
Hi @bear-is-asleep @kjplows |
|
Hi @absolution1 , that's right - the offending PR was reverted in larsoft v10_04_04 and a new sbncode release is being prepped right now. I agree the reverting procedure should go ahead as soon as the release is out (hopefully before this evening UK time) |
|
Just to follow up - sbncode v10_04_04 is out so we're good to go about reverting this @bear-is-asleep . Thanks! |
|
I've issued the revert PR: #670 |
Description
This PR disables the vertex refinement in SBND's pandora workflow. This is a temporary change while an upstream larcontent issue is resolved.
This PR will mean vertex positions are less precise, but otherwise should not impact the downstream reco.
Thanks @henrylay97 for helping to understand the disabling procedure.
Checklist
Reviewers,AssigneesDevelopementRelevant PR links (optional)
Link(s) to docdb describing changes (optional)