Ensure deposits from all CRT types are retained when merging multiple geant outputs - #671
Conversation
marcodeltutto
left a comment
There was a problem hiding this comment.
Good catch, thank you, @henrylay97!
|
If only a little sooner ;) @marcodeltutto |
|
trigger build LArSoft/lar*@LARSOFT_SUITE_v10_04_03 SBNSoftware/sbnanaobj@v09_23_03 SBNSoftware/sbnobj@v10_00_04 SBNSoftware/sbncode@v10_04_03 |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
@henrylay97 there are no g4 product size differences, not sure if you expect something like more sim energy deposits from including these volumes? |
|
The changes impact the dirt and rockbox generation only, which are not tested in the CI. So the result is espected. But, this points to the fact that we should add a CI test for rockbox |
|
As @marcodeltutto says because of the workflow - I wouldn't expect a change. A rockbox workflow would be good - anything with a filter provides problems for reproducing numbers of events but I'm sure this could be worked around. |
|
Approved |
Description
Bug found during Analysis Workshop. GDML adopted in December/January introduced a number of new "types" of CRT. These need explicity listing in this fcl otherwise the energy deposits in them get dropped in any MC workflows with multiple geant4 instances (like rockbox or intime samples).
Our MC testing was done with a pure cosmics sample so we didn't encounter this.
For anyone looking at the samples - this impacts the Top & some of the North CRTs.
Checklist
Reviewers,AssigneesDevelopementRelevant PR links (optional)
N/A
Link(s) to docdb describing changes (optional)
I will mention it in a future docDB about CRT-TPC matching and try to remember to link it here.