Skip to content

Ensure deposits from all CRT types are retained when merging multiple geant outputs - #671

Merged
bear-is-asleep merged 1 commit into
developfrom
bugfix/hlay_crt_merge_sim_sources
Mar 10, 2025
Merged

Ensure deposits from all CRT types are retained when merging multiple geant outputs#671
bear-is-asleep merged 1 commit into
developfrom
bugfix/hlay_crt_merge_sim_sources

Conversation

@henrylay97

@henrylay97 henrylay97 commented Feb 28, 2025

Copy link
Copy Markdown
Member

Description

Bug found during Analysis Workshop. GDML adopted in December/January introduced a number of new "types" of CRT. These need explicity listing in this fcl otherwise the energy deposits in them get dropped in any MC workflows with multiple geant4 instances (like rockbox or intime samples).

Our MC testing was done with a pure cosmics sample so we didn't encounter this.

For anyone looking at the samples - this impacts the Top & some of the North CRTs.

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • Linked any relevant issues under Developement
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
  • Does this affect the standard workflow?

Relevant PR links (optional)

N/A

Link(s) to docdb describing changes (optional)

I will mention it in a future docDB about CRT-TPC matching and try to remember to link it here.

@henrylay97 henrylay97 added bug Something isn't working crt Cosmic Ray Tagger simulation genie or geant4 (g4) labels Feb 28, 2025
@henrylay97 henrylay97 self-assigned this Feb 28, 2025

@marcodeltutto marcodeltutto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you, @henrylay97!

@henrylay97

Copy link
Copy Markdown
Member Author

If only a little sooner ;) @marcodeltutto

@bear-is-asleep

Copy link
Copy Markdown
Contributor

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_04_03 SBNSoftware/sbnanaobj@v09_23_03 SBNSoftware/sbnobj@v10_00_04 SBNSoftware/sbncode@v10_04_03

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@bear-is-asleep

Copy link
Copy Markdown
Contributor

@henrylay97 there are no g4 product size differences, not sure if you expect something like more sim energy deposits from including these volumes?

@marcodeltutto

Copy link
Copy Markdown
Member

The changes impact the dirt and rockbox generation only, which are not tested in the CI. So the result is espected.

But, this points to the fact that we should add a CI test for rockbox

@henrylay97

Copy link
Copy Markdown
Member Author

As @marcodeltutto says because of the workflow - I wouldn't expect a change.

A rockbox workflow would be good - anything with a filter provides problems for reproducing numbers of events but I'm sure this could be worked around.

@bear-is-asleep

Copy link
Copy Markdown
Contributor

Approved

@bear-is-asleep
bear-is-asleep merged commit 741296a into develop Mar 10, 2025
@bear-is-asleep bear-is-asleep moved this from Todo to In tagged release in SBND March 2025 production Mar 12, 2025
@henrylay97
henrylay97 deleted the bugfix/hlay_crt_merge_sim_sources branch March 23, 2026 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working crt Cosmic Ray Tagger simulation genie or geant4 (g4)

Projects

Status: In tagged release

Development

Successfully merging this pull request may close these issues.

4 participants