Skip to content

CRT Calib Fix - #676

Merged
bear-is-asleep merged 3 commits into
developfrom
feature/bearc_crt_calib_fix
Mar 10, 2025
Merged

CRT Calib Fix#676
bear-is-asleep merged 3 commits into
developfrom
feature/bearc_crt_calib_fix

Conversation

@bear-is-asleep

@bear-is-asleep bear-is-asleep commented Mar 10, 2025

Copy link
Copy Markdown
Contributor

Description

Fixes PR #643 to remove crt skim outputs from standard reco workflow. The error arises when testing reco_sbnd.fcl in the unit tests which failed silently.

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • [na] Linked any relevant issues under Developement
  • [na] Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
  • Does this affect the standard workflow?

@bear-is-asleep bear-is-asleep added the crt Cosmic Ray Tagger label Mar 10, 2025
@bear-is-asleep bear-is-asleep self-assigned this Mar 10, 2025
@bear-is-asleep
bear-is-asleep marked this pull request as ready for review March 10, 2025 21:19
@bear-is-asleep

Copy link
Copy Markdown
Contributor Author

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_04_03 SBNSoftware/sbnanaobj@v09_23_03 SBNSoftware/sbnobj@v10_00_04 SBNSoftware/sbncode@v10_04_03

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@bear-is-asleep

Copy link
Copy Markdown
Contributor Author

Bypassing checks. I asked @linyan-w if the crt skim is needed, but it's not as it's been moved to crtana in reco2.

@bear-is-asleep
bear-is-asleep merged commit b04c46f into develop Mar 10, 2025
@bear-is-asleep
bear-is-asleep deleted the feature/bearc_crt_calib_fix branch March 10, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

crt Cosmic Ray Tagger

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants