Skip to content

Add fcls for DNN ROI validation production#759

Closed
linyan-w wants to merge 1 commit intodevelopfrom
feature/linyan-DNNValProd
Closed

Add fcls for DNN ROI validation production#759
linyan-w wants to merge 1 commit intodevelopfrom
feature/linyan-DNNValProd

Conversation

@linyan-w
Copy link
Copy Markdown
Contributor

@linyan-w linyan-w commented Jul 18, 2025

Description

Please provide a detailed description of the changes this pull request introduces.

This PR adds fcls for DNN ROI validation production which includes both DNN and traditional ROI for both data and MC. It needs to be merged by the end of July.
These production specific fcls are renamed to distinguish from standard fcls. After the validation production, the workflow will be changed to remove one of the ROI stream and move the the other to the standard fcls.

$${\color{red}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$

$${\color{red}\bf{\textrm{IMPORTANT UPDATE June 22nd 2025:}}}$$ If you are making a PR which is intended as a patch for the CURRENT production (which started in Spring 2025), you must make two PRs: one for develop and one for the production/v10_06_00 branch.

$${\color{red}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • Linked any relevant issues under Developement
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
  • Does this affect the standard workflow?
  • Is this PR a patch for the ongoing production? If so, separate PR must also be made for production/v10_06_00 branch!

Relevant PR links (optional)

Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?

Link(s) to docdb describing changes (optional)

Is there a docdb describing the issue this solves or the feature added?

@linyan-w linyan-w self-assigned this Jul 18, 2025
@linyan-w linyan-w added detsim Detector simulation reco1/reco2 Reconstruction labels Jul 18, 2025
@linyan-w linyan-w closed this Jul 21, 2025
@linyan-w linyan-w deleted the feature/linyan-DNNValProd branch July 21, 2025 16:08
@linyan-w linyan-w moved this to Approved in SBND 2025 Fall Production Jul 24, 2025
@linyan-w linyan-w moved this from Approved to In tagged release in SBND 2025 Fall Production Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

detsim Detector simulation reco1/reco2 Reconstruction

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant