Skip to content

Adding low threshold settings to reco1#762

Merged
nathanielerowe merged 41 commits intodevelopfrom
feature/JacobLowThresholdTools
Aug 26, 2025
Merged

Adding low threshold settings to reco1#762
nathanielerowe merged 41 commits intodevelopfrom
feature/JacobLowThresholdTools

Conversation

@Jjm321814
Copy link
Copy Markdown
Contributor

@Jjm321814 Jjm321814 commented Jul 18, 2025

Added additional reco1.fcl files and wirecell .jsonnet files
This allows us to have an optional low threshold reconstruction path that is entirely non-destructive to the baseline processing.
We would like this in the next sbndcode release to have more validations done along with DNN roi work.

Also added blip reco directory so we can submit production requests for large numbers of blips.

@Jjm321814 Jjm321814 self-assigned this Jul 18, 2025
@linyan-w
Copy link
Copy Markdown
Contributor

linyan-w commented Jul 18, 2025

Part of DNN ROI validation production. Pending group meeting discussion. Should be merged after #759 . Need additional reviewers (Dom and maybe Hanyu or Moon?)

@SBNSoftware SBNSoftware deleted a comment from FNALbuild Aug 22, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Aug 22, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Aug 22, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Aug 22, 2025
@linyan-w
Copy link
Copy Markdown
Contributor

@Jjm321814 The CI is throwing this error. Do you know what fcl this should be pointing to? Could also be because of the CI issues, but only saw one instance of sbnd_calorimetryalgmc in the fcls so wanted to flag it in case it was an easy fix.

53: Local lookup error 54: ---- Can't find key BEGIN 55: sbnd_calorimetryalgmc (at part "sbnd_calorimetryalgmc") 56: ---- Can't find key END 57: at line 31, character 25, of file "/scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/build_slf7.x86_64/sbndcode/fcl/blipreco_configs.fcl" 58: 59: CaloAlg: @Local::sbnd_calorimetryalgmc 60: ^ 61: ---- Parse error END

This line looks fine to me... This is part of blipreco (instead of LE DNN - another reason that in the future we should split features into different PRs). Sungbin tested blipreco part of this PR already. I can try to test again tomorrow.

@SBNSoftware SBNSoftware deleted a comment from FNALbuild Aug 22, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Aug 22, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Aug 22, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Aug 22, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Aug 22, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Aug 22, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Aug 22, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Aug 22, 2025
@nathanielerowe
Copy link
Copy Markdown
Contributor

trigger build ci_ref=v10_06_02 LArSoft/lar*@LARSOFT_SUITE_v10_09_00 SBNSoftware/sbncode@v10_09_00 SBNSoftware/sbnalg@v10_09_00 SBNSoftware/sbnobj@v10_01_02 SBNSoftware/sbnanaobj@v10_00_06 SBNSoftware/sbndaq_artdaq_core@v1_10_06 SBNSoftware/sbndata@v01_07 SBNSoftware/sbndutil@v10_06_00_02 SBNSoftware/sbnd_data@v01_34_00

@FNALbuild
Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored failure for unit_test - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@nathanielerowe
Copy link
Copy Markdown
Contributor

trigger build ci_ref=v10_06_02 LArSoft/lar*@LARSOFT_SUITE_v10_09_00 SBNSoftware/sbncode@v10_09_00 SBNSoftware/sbnalg@v10_09_00 SBNSoftware/sbnobj@v10_01_02 SBNSoftware/sbnanaobj@v10_00_06 SBNSoftware/sbndaq_artdaq_core@v1_10_06 SBNSoftware/sbndata@v01_07 SBNSoftware/sbndutil@v10_06_00_02 SBNSoftware/sbnd_data@v01_34_00

@FNALbuild
Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@Jjm321814
Copy link
Copy Markdown
Contributor Author

The CI dashboard is a bit difficult to interpret. It looks like sbnd_ci/18007 completed? Is there a specific error message to interpret and fix to get this to move forward?

@nathanielerowe
Copy link
Copy Markdown
Contributor

@Jjm321814 there is no particular issue with your PR at the moment. The main thing holding us back from merging this and cutting a release is that we are currently missing reference files for the latest releases to compare the output of this PR against (this manifests as a bunch of warnings in the ci_tests phase, but possible other effects as well).

The person who normally makes those is not able to, so I am working on getting them on my own. I will either have them or accept what we have as "validated enough" by tonight.

@nathanielerowe
Copy link
Copy Markdown
Contributor

Approved

@nathanielerowe nathanielerowe merged commit f1870dc into develop Aug 26, 2025
@linyan-w linyan-w moved this from Approved to In tagged release in SBND 2025 Fall Production Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In tagged release

Development

Successfully merging this pull request may close these issues.

6 participants