Add wc_device jsonnet parameter and gpu_fcls#766
Merged
Conversation
Contributor
Author
|
@wjdanswjddl Can you merge this into your branch today? |
wjdanswjddl
approved these changes
Jul 24, 2025
wjdanswjddl
left a comment
wjdanswjddl
left a comment
Contributor
There was a problem hiding this comment.
looks good to me -- thanks for putting this together
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just wanted to add this to Mun's feature branch to avoid merge conflicts from trying to merge both into develop at the same time. This enables variable device selection in the DFT and ts model loading. Set using the same methods as was done in icaruscode.
Have confirmed that standard_detsim_sbnd.fcl still works and the GPU activity is non-zero when running the appropriate fcls. If there is any other kind of validation requested, let me know!