Skip to content

Apply the commit from PR #845 to production/v10_06_00#851

Merged
seokjuchung merged 1 commit into
production/v10_06_00from
trj_pr845_to_production_v10_06_00
Nov 5, 2025
Merged

Apply the commit from PR #845 to production/v10_06_00#851
seokjuchung merged 1 commit into
production/v10_06_00from
trj_pr845_to_production_v10_06_00

Conversation

@tomjunk

@tomjunk tomjunk commented Oct 17, 2025

Copy link
Copy Markdown
Contributor

This is a copy of PR #845 which is a new cold electronics digital noise event filter. PR #845 targets develop, and this is a copy for production/v10_06_00. It uses anab::TPCChannelInfo as the input data product and thus should run on decoded artROOT files as well as reco1 files and any downstream files that retain this data product.

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • Is this PR a patch for the ongoing production? If so, separate PR must also be made for production/v10_06_00 branch!

Link(s) to docdb describing changes (optional)

See SBN-Doc-43924 describing this filter and SBN-Doc-43681 and SBN-Doc-43477 for earlier work.

@nathanielerowe

Copy link
Copy Markdown
Contributor

@seokjuchung I think you already looked at the develop version of this, but please also take a look at this!

@jzennamo jzennamo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not get to review the module in detail, but I can see how this will fit into our production workflows.

@seokjuchung
seokjuchung merged commit 8a2cc48 into production/v10_06_00 Nov 5, 2025

@seokjuchung seokjuchung left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants