Apply the commit from PR #845 to production/v10_06_00#851
Merged
seokjuchung merged 1 commit intoNov 5, 2025
Conversation
Contributor
|
@seokjuchung I think you already looked at the develop version of this, but please also take a look at this! |
jzennamo
approved these changes
Nov 5, 2025
jzennamo
left a comment
Contributor
There was a problem hiding this comment.
I did not get to review the module in detail, but I can see how this will fit into our production workflows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a copy of PR #845 which is a new cold electronics digital noise event filter. PR #845 targets develop, and this is a copy for production/v10_06_00. It uses anab::TPCChannelInfo as the input data product and thus should run on decoded artROOT files as well as reco1 files and any downstream files that retain this data product.
Checklist
Reviewers,AssigneesLink(s) to docdb describing changes (optional)
See SBN-Doc-43924 describing this filter and SBN-Doc-43681 and SBN-Doc-43477 for earlier work.