Conversation
Add CMake check for mallctl and use it in PCU_GetMem if available. Add private PCU link to libexecinfo on BSD. Enable pcu/reel/reel.c functions on BSD. Signed-off-by: Aiden Woodruff <woodra@rpi.edu>
Collaborator
Author
|
This builds successfully on our FreeBSD VM. |
bobpaw
commented
Jan 4, 2024
cwsmith
requested changes
Jan 4, 2024
Contributor
cwsmith
left a comment
cwsmith
left a comment
There was a problem hiding this comment.
LGTM. Thank you. There is one small change/comment.
Signed-off-by: Aiden Woodruff <woodra@rpi.edu>
Removed if(GNU or CLANG) because if these checks pass, we can use it on non-GNU systems as well. Removed get_chunks() in test/describe.cc and replaced get_peak() with PCU_GetMem(). Signed-off-by: Aiden Woodruff <woodra@rpi.edu>
Contributor
|
@bobpaw Thank you for working on this. Please change it to an 'active' (i.e., not draft) PR when its ready for another review. |
Collaborator
Author
|
Confirmed that tests pass on our BSD box. Marking ready for review. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increased platform support for PCU
Add CMake check for mallctl and use it in PCU_GetMem if available (for BSD).
Add private PCU link to libexecinfo on BSD.
Enable pcu/reel/reel.c functions on BSD.
Make PUMI_HAS_MALLINFO, PUMI_HAS_MALLINFO2, PUMI_HAS_MALLCTL private compiler definitions for pcu.
Fixes #409