Add -j support - #12
Merged
Merged
Conversation
|
The alternative is to follow the Python 3 direction and support a key function instead of cmp. |
Contributor
Author
|
@timj - The issue though is we'd break compatibility without SCons' deprecation cycle. |
… GenerateHelpText() is now actually called.
bdbaddog
changed the title
mwichmann
reviewed
Oct 12, 2017
| env - an environment that is used to get the current values | ||
| of the options. | ||
| cmp - Either a function as follows: The specific sort function should take two arguments and return -1, 0 or 1 | ||
| or a boolean to indicate if it should be sorted. |
Collaborator
There was a problem hiding this comment.
this might read less awkwardly if reversed: Either True/False to indicate whether to sort using defaults, or the name of a function to use for sorting. The specific sort function should take two arguments and return -1, 0 or 1.
mwichmann
reviewed
Oct 12, 2017
|
|
||
|
|
||
|
|
||
| # No cmp in py3, so we'll define it. |
Collaborator
There was a problem hiding this comment.
probably don't need the comment since you have the docstring
Collaborator
|
Looks reasonable to me. Left some comments on non-code portions. |
bdbaddog
changed the title
bdbaddog
added a commit
that referenced
this pull request
Aug 3, 2025
Add consvar for TEMPFILE encoding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue was originally created at: 2001-07-19 22:00:00.
This issue was reported by:
stevenknight.stevenknight said at 2001-07-19 22:00:00
issues@scons said at 2001-07-25 22:00:00
stevenknight said at 2006-05-20 20:48:13