Merged
Conversation
Collaborator
Author
|
To be addressed in the next PR: Having one |
76e5186 to
81101aa
Compare
The RL pipeline is not working properly with the new refactor including: - Input/Output results - Config files
arashr88
approved these changes
Aug 12, 2025
Refactor/rl cli
ryanmccann1024
added a commit
that referenced
this pull request
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR reorganizes core simulation and module logic into a cleaner and more maintainable directory structure under
fusion/core/. Specifically:simulation.py,routing.py,spectrum_assignment.py,request_generator.py,snr_measurements.py, andsdn_controller.pyintofusion/core/for semantic clarity and long-term scalability.batch_runner.py, which has now been removed.fusionpackage to ensure consistent style across the refactored modules.These structural changes reduce clutter in
fusion/sim/and establishfusion/core/as the authoritative home for reusable simulation engine logic, allowingfusion/sim/to focus exclusively on pipeline orchestration.Fixes: # (issue number) ---
🧐 Type of Change
💥 Impact of Breaking Change
This is a major structural breaking change:
fusion/sim/must update their import paths to usefusion/core/.batch_runner.pymodule was removed entirely. Any scripts depending on it must revert to usingnetwork_simulator.run()or refactor accordingly.All internal CLI entrypoints (
run_sim.py,run_train.py, etc.) have been updated to work with the new structure.🧪 How Has This Been Tested?
All changes were validated by:
python -m fusion.cli.run_sim --config_path ini/run_ini/config.inifusion/Test Configuration:
requirements.txtenvironment📸 Screenshots / Screen Recordings
N/A
✅ Final Checklist