Skip to content

Remove unneeded auth classes. Fix BuildingSync and HPXML API endpoints#1611

Merged
nllong merged 4 commits intodevelopfrom
auth-classes-bsxml-hpxml
Apr 13, 2018
Merged

Remove unneeded auth classes. Fix BuildingSync and HPXML API endpoints#1611
nllong merged 4 commits intodevelopfrom
auth-classes-bsxml-hpxml

Conversation

@nllong
Copy link
Member

@nllong nllong commented Apr 12, 2018

Any background context you want to provide?

BuildingSync and HPXML were displaying quantities in the elements.

What's this PR do?

Cast the Quantity fields to their magnitudes before persisting to the XML's (BuildingSync and HPXML).

How should this be manually tested?

Unit tests were added.

Go to the following endpoints via the API:

  • /api/v2.1/properties/234/building_sync/?cycle_id=x
  • /api/v2.1/properties/234/hpxml/?cycle_id=x

What are the relevant tickets?

N/A

Screenshots (if appropriate)

Definition of Done:

  • Is there appropriate test coverage? (e.g. ChefSpec, Mocha/Chai, Python, etc.)
  • Does this PR require a Selenium test? (e.g. Browser-specific bugs or complicated UI bugs)
  • Does this PR require a regression test? All fixes require a regression test.
  • Does this add new dependencies? If so, does PIP, npm, bower requirements need to be updated?

@nllong nllong requested a review from axelstudios April 12, 2018 19:15
@nllong nllong merged commit 21a10cc into develop Apr 13, 2018
@nllong nllong deleted the auth-classes-bsxml-hpxml branch April 13, 2018 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants