Remove unused RESOURCES_DIR cmake option#3378
Merged
ChrisThrasher merged 1 commit intoSFML:masterfrom Jan 5, 2025
Merged
Conversation
ChrisThrasher
approved these changes
Jan 5, 2025
Member
ChrisThrasher
left a comment
There was a problem hiding this comment.
Good find! This also implies that we can collapse the directory structure of the resources themselves. We can simply put the resources in the same directory as the C++ code. I might do that in a later PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since 27a4c83 the examples are no longer installed.
Now the
RESOURCES_DIRoption is still parsed but is fully ignored, so remove it.Tasks