Skip to content

Remove unused RESOURCES_DIR cmake option#3378

Merged
ChrisThrasher merged 1 commit intoSFML:masterfrom
learn-more:obsolete_resources_dir
Jan 5, 2025
Merged

Remove unused RESOURCES_DIR cmake option#3378
ChrisThrasher merged 1 commit intoSFML:masterfrom
learn-more:obsolete_resources_dir

Conversation

@learn-more
Copy link
Copy Markdown
Contributor

  • Has this change been discussed on the forum or in an issue before?
  • Does the code follow the SFML Code Style Guide?
  • Have you provided some example/test code for your changes?
  • If you have additional steps which need to be performed, please list them as tasks!

Description

Since 27a4c83 the examples are no longer installed.
Now the RESOURCES_DIR option is still parsed but is fully ignored, so remove it.

Tasks

  • Tested on Linux
  • Tested on Windows
  • Tested on macOS
  • Tested on iOS
  • Tested on Android

Copy link
Copy Markdown
Member

@ChrisThrasher ChrisThrasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find! This also implies that we can collapse the directory structure of the resources themselves. We can simply put the resources in the same directory as the C++ code. I might do that in a later PR.

@ChrisThrasher ChrisThrasher merged commit bc268fb into SFML:master Jan 5, 2025
@eXpl0it3r eXpl0it3r modified the milestones: 3.0.1, 3.1 Jan 5, 2025
@learn-more learn-more deleted the obsolete_resources_dir branch January 6, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants