Test opening sound files with non-ASCII filenames#3415
Merged
ChrisThrasher merged 1 commit intomasterfrom Feb 2, 2025
Merged
Conversation
21 tasks
ChrisThrasher
force-pushed
the
test_sound_file_unicode
branch
from
7800352 to
f1fd29b
Compare
ChrisThrasher
force-pushed
the
test_sound_file_unicode
branch
from
f1fd29b to
e6c26ef
Compare
eXpl0it3r
approved these changes
Feb 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We need to test with all possible file formats because each format follows unique codepaths that marshal out to their respective libraries. We will also use these extra files in future tests so it's useful to add them now.