Implement modular helpers and Pydantic models for reviewer logic - #17
Merged
Conversation
… reviewer recommendation and orchestration logic
…del to qwen2.5:0.5b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the API and supporting code for the reviewer recommendation system to improve maintainability, modularity, and clarity. The main changes include extracting helper functions and data models into separate modules, updating API endpoints and request models for clarity, and making a minor model selection update for skill extraction.
Key changes:
Refactoring and Modularization:
codience/src/app.pyinto a newcodience/src/helpers.pymodule, significantly simplifying the main API file and improving code organization. [1] [2] [3] [4]codience/src/app.pyinto a newcodience/src/models.pymodule, clarifying model definitions and reducing clutter in the API logic. [1] [2]API Endpoint and Model Updates:
/api/recommend/v2to/api/recommend-reviewersand updated the request model toRecommendReviewersRequestfor more explicit naming and usage. [1] [2]Reviewer Recommendation Logic:
helpers.pyfor easier testing and reuse, and clarified the scoring process. [1] [2]helpers.py, separating business logic from API routing. [1] [2]Skill Extraction Model Update:
batch_skill_extractor.pyfrom"phi3:mini"to"qwen2.5:0.5b", likely for improved performance or accuracy.These changes collectively make the codebase cleaner, more modular, and easier to extend or maintain.