ci: add coverage thresholds and reporting#378
Merged
IbrahimIjai merged 1 commit intoJul 25, 2026
Merged
Conversation
|
@0takuc0mrade is attempting to deploy a commit to the Ijai's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@0takuc0mrade Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
0takuc0mrade
marked this pull request as ready for review
July 25, 2026 02:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
turbo test:coveragetask and runs it in CI even when an unrelated earlier check failsWhy
The repository had a shared V8 provider but no enforced baseline, no root coverage command, and no CI reporting. The web package currently uses Bun rather than Vitest for its active test runner, so its gate is configured in
bunfig.toml; contracts retain their Vitest configuration.The normal web test command is preserved. Passing
--coverage, as required by the issue, selects the currently stable unit-test surface instead of pulling pre-existing runner-incompatible suites into the new gate.Measured baseline
The contracts coverage task excludes the existing generated-binding smoke file because upstream currently expects an
ExchangeRouterGenerated.Clientexport that the generated package does not provide. Generated code remains outside the coverage target.Validation
bun run --cwd apps/web test -- --coverage— 75 passedbun run --cwd packages/contracts test:coverage— 174 passedbun run test:coverage— 2/2 Turbo tasks passedExisting upstream status
Upstream
mainis already red:bun run lintreports 208 existing web lint findings before these changes. This PR deliberately does not expand into that unrelated cleanup.Closes #339