test(shared): cover pagination boundaries#381
Merged
IbrahimIjai merged 1 commit intoJul 25, 2026
Merged
Conversation
|
@0takuc0mrade is attempting to deploy a commit to the Ijai's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@0takuc0mrade Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
0takuc0mrade
marked this pull request as ready for review
July 25, 2026 02:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PaginationcomponentWhy
Upstream
maindid not contain the component named by the issue. The new API uses one conventionalonPageChange(page)callback and native button semantics, keeping the component small and reusable.Validation
user-eventplus role/text queriesTests verify previous/next callback values, first/last boundaries, a single page, and zero pages.
The repository-wide checks remain affected by pre-existing upstream lint/typecheck failures outside these two new files.
Closes #342