Fix: remove accidental pyspark dependency added in ruff refactor#2587
Merged
georgesittas merged 1 commit intomainfrom May 9, 2024
Merged
Fix: remove accidental pyspark dependency added in ruff refactor#2587georgesittas merged 1 commit intomainfrom
georgesittas merged 1 commit intomainfrom
Conversation
georgesittas
force-pushed
the
jo/remove_accidental_pyspark_dependency
branch
from
d5bf488 to
d013e29
Compare
tobymao
approved these changes
May 8, 2024
georgesittas
force-pushed
the
jo/remove_accidental_pyspark_dependency
branch
from
d013e29 to
136b1d8
Compare
georgesittas
force-pushed
the
jo/remove_accidental_pyspark_dependency
branch
from
136b1d8 to
0584aba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2584 accidentally added pyspark as a dependency. This PR removes the dependency again and refactors the branch that instance-checked the df against
pyspark.sql.dataframe.DataFrame, so that there's no need to import pyspark in order to reference this type. It's achieved by ensuringquery_or_df's type doesn't match any other type in theQueryOrDFunion, so we can conclude that it's a pyspark dataframe.