Skip to content

Fix: remove accidental pyspark dependency added in ruff refactor #2587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
georgesittas merged 1 commit into from
May 9, 2024
Merged

Fix: remove accidental pyspark dependency added in ruff refactor #2587

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions sqlmesh/core/snapshot/evaluator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
from functools import reduce

import pandas as pd
from pyspark.sql.dataframe import DataFrame as PySparkDataFrame
from sqlglot import exp, select
from sqlglot.executor import execute

Expand Down Expand Up @@ -544,10 +543,13 @@ def apply(query_or_df: QueryOrDF, index: int = 0) -> None:

if limit is not None:
query_or_df = next(queries_or_dfs)
if isinstance(query_or_df, PySparkDataFrame):
return query_or_df.limit(limit)
if isinstance(query_or_df, pd.DataFrame):
return query_or_df.head(limit)
if not isinstance(query_or_df, exp.Expression):
# We assume that if this branch is reached, `query_or_df` is a pyspark dataframe,
# so we use `limit` instead of `head` to get back a dataframe instead of List[Row]
# https://spark.apache.org/docs/3.1.1/api/python/reference/api/pyspark.sql.DataFrame.head.html#pyspark.sql.DataFrame.head
return query_or_df.limit(limit)

assert isinstance(query_or_df, exp.Query)

Expand Down