Tests: Fix ipa multihost test_authentication_indicators#8525
Merged
jakub-vavra-cz merged 1 commit intoSSSD:masterfrom Mar 17, 2026
Merged
Tests: Fix ipa multihost test_authentication_indicators#8525jakub-vavra-cz merged 1 commit intoSSSD:masterfrom
jakub-vavra-cz merged 1 commit intoSSSD:masterfrom
Conversation
aborah-sudo
added
Tests
Trivial
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request fixes a test by adding a time.sleep() to wait for a sudo rule to propagate. While this can fix the immediate issue, using fixed sleeps in tests is an anti-pattern that can lead to either flaky or slow tests. I've suggested replacing the sleep with a more robust polling mechanism that retries the operation until it succeeds or a timeout is reached. This will make the test more reliable and efficient.
Provide sleep time to test Reviewed-by: Jakub Vávra <jvavra@redhat.com>
Contributor
This was referenced Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide sleep time to test