Skip to content

[autobackport: sssd-2-12] Tests: Fix ipa multihost test_authentication_indicators#8529

Merged
jakub-vavra-cz merged 1 commit intoSSSD:sssd-2-12from
sssd-bot:SSSD-sssd-backport-pr8525-to-sssd-2-12
Mar 17, 2026
Merged

[autobackport: sssd-2-12] Tests: Fix ipa multihost test_authentication_indicators#8529
jakub-vavra-cz merged 1 commit intoSSSD:sssd-2-12from
sssd-bot:SSSD-sssd-backport-pr8525-to-sssd-2-12

Conversation

@sssd-bot
Copy link
Contributor

This is an automatic backport of PR#8525 Tests: Fix ipa multihost test_authentication_indicators to branch sssd-2-12, created by @aborah-sudo.

Please make sure this backport is correct.

Note

The commits were cherry-picked without conflicts.

You can push changes to this pull request

git remote add sssd-bot git@github.com:sssd-bot/sssd.git
git fetch sssd-bot refs/heads/SSSD-sssd-backport-pr8525-to-sssd-2-12
git checkout SSSD-sssd-backport-pr8525-to-sssd-2-12
git push sssd-bot SSSD-sssd-backport-pr8525-to-sssd-2-12 --force

Original commits
a6d0f0c - Tests: Fix ipa multihost test_authentication_indicators

Backported commits

  • d87f6a2 - Tests: Fix ipa multihost test_authentication_indicators

Original Pull Request Body

Provide sleep time to test

Provide sleep time to test

Reviewed-by: Jakub Vávra <jvavra@redhat.com>
(cherry picked from commit a6d0f0c)
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request backports a fix for a flaky test, test_authentication_indicators, by adding a time.sleep(5) to allow for sudo rule propagation. While this addresses the immediate issue, I've suggested a more robust polling mechanism to avoid the potential pitfalls of fixed sleeps in tests, which can lead to either continued flakiness or slow test execution.

Copy link
Contributor

@jakub-vavra-cz jakub-vavra-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jakub-vavra-cz jakub-vavra-cz added Accepted Tests Trivial A single reviewer is sufficient to review the Pull Request labels Mar 17, 2026
@jakub-vavra-cz jakub-vavra-cz merged commit 60d877c into SSSD:sssd-2-12 Mar 17, 2026
8 of 13 checks passed
@sssd-bot
Copy link
Contributor Author

The pull request was accepted by @jakub-vavra-cz with the following PR CI status:


🟡 rpm-build:centos-stream-10-x86_64:upstream (in_progress)
🟡 rpm-build:fedora-42-x86_64:upstream (in_progress)
🟡 rpm-build:fedora-43-x86_64:upstream (in_progress)
🟡 rpm-build:fedora-44-x86_64:upstream (in_progress)
🔴 rpm-build:fedora-rawhide-x86_64:upstream (failure)
🟢 Build / freebsd (success)
🟡 Build / make-distcheck (in_progress)


There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Accepted Tests Trivial A single reviewer is sufficient to review the Pull Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants