Fix contents of release tarball#8582
Merged
alexey-tikhonov merged 2 commits intoSSSD:masterfrom Apr 13, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates Makefile.am to include new CI scripts, Vagrant configurations, and a dist-hook for cleaning up build artifacts. It also removes outdated documentation and CI task definitions. Feedback suggests correctly categorizing files to ensure proper distribution: executable scripts should be moved to dist_noinst_SCRIPTS to preserve permissions, and directories should be moved to EXTRA_DIST to prevent nested directory issues during the build process.
Member
Author
|
Fixed. I didn't use EXTRA_DIST but rather expand the folders. |
alexey-tikhonov
approved these changes
Apr 13, 2026
This was used by sssd-test-suite virtual machines based CI that we no longer use. Reviewed-by: Alexey Tikhonov <atikhono@redhat.com> Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com>
The tarball contained malformed src/tests/tests folder due to including full src/tests in noinst_DATA (because $distdir/src/tests was already created by check unit tests). It also clean up the tarball to avoid various build time artifacts and including missing files. Resolves: SSSD#8514 Reviewed-by: Alexey Tikhonov <atikhono@redhat.com> Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tarball contained malformed src/tests/tests folder due to including
full src/tests in noinst_DATA (because $distdir/src/tests was already
created by check unit tests).
It also clean up the tarball to avoid various build time artifacts and
including missing files.
Resolves: #8514