Skip to content

[autobackport: sssd-2-9] Fix contents of release tarball#8593

Merged
alexey-tikhonov merged 2 commits intoSSSD:sssd-2-9from
sssd-bot:SSSD-sssd-backport-pr8582-to-sssd-2-9
Apr 13, 2026
Merged

[autobackport: sssd-2-9] Fix contents of release tarball#8593
alexey-tikhonov merged 2 commits intoSSSD:sssd-2-9from
sssd-bot:SSSD-sssd-backport-pr8582-to-sssd-2-9

Conversation

@sssd-bot
Copy link
Copy Markdown
Contributor

This is an automatic backport of PR#8582 Fix contents of release tarball to branch sssd-2-9, created by @pbrezina.

Please make sure this backport is correct.

Note

The commits were cherry-picked without conflicts.

You can push changes to this pull request

git remote add sssd-bot git@github.com:sssd-bot/sssd.git
git fetch sssd-bot refs/heads/SSSD-sssd-backport-pr8582-to-sssd-2-9
git checkout SSSD-sssd-backport-pr8582-to-sssd-2-9
git push sssd-bot SSSD-sssd-backport-pr8582-to-sssd-2-9 --force

Original commits
3b7dc8c - contrib: removed unused test-suite
f260623 - dist: clean up and fix ditribution tarball

Backported commits

  • 28b2c69 - contrib: removed unused test-suite
  • 9ab3841 - dist: clean up and fix ditribution tarball

Original Pull Request Body

The tarball contained malformed src/tests/tests folder due to including
full src/tests in noinst_DATA (because $distdir/src/tests was already
created by check unit tests).

It also clean up the tarball to avoid various build time artifacts and
including missing files.

Resolves: #8514

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates Makefile.am to include several CI scripts, GDB plugins, and configuration files in the distribution. It also introduces a dist-hook to remove build artifacts and cache directories such as pycache and .pytest_cache during the distribution process. Additionally, some CI-related documentation and configuration files were removed. I have no feedback to provide.

@alexey-tikhonov alexey-tikhonov removed the request for review from ikerexxe April 13, 2026 10:52
@alexey-tikhonov alexey-tikhonov added no-backport This should go to target branch only. Accepted labels Apr 13, 2026
This was used by sssd-test-suite virtual machines based CI that we no
longer use.

Reviewed-by: Alexey Tikhonov <atikhono@redhat.com>
Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com>
(cherry picked from commit 3b7dc8c)
The tarball contained malformed src/tests/tests folder due to including
full src/tests in noinst_DATA (because $distdir/src/tests was already
created by check unit tests).

It also clean up the tarball to avoid various build time artifacts and
including missing files.

Resolves: SSSD#8514
Reviewed-by: Alexey Tikhonov <atikhono@redhat.com>
Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com>
(cherry picked from commit f260623)
@sssd-bot
Copy link
Copy Markdown
Contributor Author

The pull request was accepted by @alexey-tikhonov with the following PR CI status:


🟢 CodeQL (success)
🟢 rpm-build:centos-stream-9-x86_64:upstream (success)
🟢 Build / make-distcheck (success)
🟢 ci / prepare (success)
🟢 ci / system (centos-9) (success)
🟢 Static code analysis / codeql (success)
🟢 Static code analysis / pre-commit (success)
🟢 Static code analysis / python-system-tests (success)


There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging.

@sssd-bot sssd-bot force-pushed the SSSD-sssd-backport-pr8582-to-sssd-2-9 branch from 9ab3841 to 089cdb2 Compare April 13, 2026 13:26
@alexey-tikhonov alexey-tikhonov merged commit cf35a8f into SSSD:sssd-2-9 Apr 13, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Accepted no-backport This should go to target branch only.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants