Tests: LDAP+KRB5 krb_misc tests#8612
Merged
spoore1 merged 1 commit intoSSSD:masterfrom Apr 27, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces several new system tests for Kerberos authentication in SSSD, covering scenarios such as unresolvable kpasswd servers, authentication stability when processes with high UIDs (specifically -1) are running, and password changes via SSH. The review feedback suggests improving the robustness of process cleanup by using specific PIDs instead of pkill and recommends truncating log files before performing assertions to ensure test isolation and accuracy.
madhuriupadhye
force-pushed
the
ldap_krb3
branch
6 times, most recently
from
d712a93 to
440eba8
Compare
Contributor
Author
|
/packit test |
madhuriupadhye
force-pushed
the
ldap_krb3
branch
from
440eba8 to
1cd2c88
Compare
Contributor
Author
|
/test-system-scoped |
1 similar comment
Contributor
Author
|
/test-system-scoped |
madhuriupadhye
force-pushed
the
ldap_krb3
branch
2 times, most recently
from
3247d28 to
93efea5
Compare
madhuriupadhye
force-pushed
the
ldap_krb3
branch
4 times, most recently
from
dc1f92f to
10d0c97
Compare
aplopez
reviewed
Apr 24, 2026
spoore1
requested changes
Apr 27, 2026
Contributor
spoore1
left a comment
spoore1
left a comment
There was a problem hiding this comment.
This looks good. Most of my comments/questions/suggestions are small things.
madhuriupadhye
force-pushed
the
ldap_krb3
branch
from
10d0c97 to
4192055
Compare
spoore1
approved these changes
Apr 27, 2026
Contributor
spoore1
left a comment
spoore1
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the updates.
madhuriupadhye
force-pushed
the
ldap_krb3
branch
from
992637b to
4192055
Compare
Contributor
|
FYI, I removed accepted label to get a full ci run in the accepted message. |
Ported following test case: - kpasswd: BZ 847039: login works when krb5_kpasswd is unresolvable (kpasswd not needed for auth). - high UID: BZ 798655: auth and logs stay clean with a setuid(-1) helper process running. - password change: GH 677: SSH passwd with chpass_provider=krb5 logs initial auth in krb5_child.log. Signed-off-by: Madhuri Upadhye <mupadhye@redhat.com> Reviewed-by: Alejandro López <allopez@redhat.com> Reviewed-by: Scott Poore <spoore@redhat.com>
Contributor
This was referenced Apr 27, 2026
sssd-bot
pushed a commit
to madhuriupadhye/sssd
that referenced
this pull request
Apr 28, 2026
Ported following test case: - kpasswd: BZ 847039: login works when krb5_kpasswd is unresolvable (kpasswd not needed for auth). - high UID: BZ 798655: auth and logs stay clean with a setuid(-1) helper process running. - password change: GH 677: SSH passwd with chpass_provider=krb5 logs initial auth in krb5_child.log. Backporting of SSSD#8612 Signed-off-by: Madhuri Upadhye <mupadhye@redhat.com> Reviewed-by: Scott Poore <spoore@redhat.com>
madhuriupadhye
added a commit
to madhuriupadhye/sssd
that referenced
this pull request
Apr 30, 2026
Ported following test case: - kpasswd: BZ 847039: login works when krb5_kpasswd is unresolvable (kpasswd not needed for auth). - high UID: BZ 798655: auth and logs stay clean with a setuid(-2) helper process running. - password change: GH 677: SSH passwd with chpass_provider=krb5 logs initial auth in krb5_child.log. Backporting of SSSD#8612 Signed-off-by: Madhuri Upadhye <mupadhye@redhat.com>
madhuriupadhye
added a commit
to madhuriupadhye/sssd
that referenced
this pull request
Apr 30, 2026
Ported following test case: - kpasswd: BZ 847039: login works when krb5_kpasswd is unresolvable (kpasswd not needed for auth). - high UID: BZ 798655: auth and logs stay clean with a setuid(-2) helper process running. - password change: GH 677: SSH passwd with chpass_provider=krb5 logs initial auth in krb5_child.log. Backporting of SSSD#8612 Signed-off-by: Madhuri Upadhye <mupadhye@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ported following test case: