[autobackport: sssd-2-12] Tests: LDAP+KRB5 krb_misc tests#8652
Open
sssd-bot wants to merge 1 commit intoSSSD:sssd-2-12from
Open
[autobackport: sssd-2-12] Tests: LDAP+KRB5 krb_misc tests#8652sssd-bot wants to merge 1 commit intoSSSD:sssd-2-12from
sssd-bot wants to merge 1 commit intoSSSD:sssd-2-12from
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces new system tests for SSSD Kerberos functionality, covering scenarios such as unresolvable kpasswd servers, handling of processes with invalid UIDs, and password changes via SSH. The review feedback identifies a technical flaw in the C helper code where setuid(-1) acts as a no-op on Linux, potentially invalidating the test for BZ 798655. Additionally, it is recommended to explicitly set the SSSD debug level to ensure that the log messages being asserted in the tests are actually generated.
madhuriupadhye
force-pushed
the
SSSD-sssd-backport-pr8612-to-sssd-2-12
branch
2 times, most recently
from
348cac5 to
c5f5092
Compare
aplopez
reviewed
Apr 30, 2026
Ported following test case: - kpasswd: BZ 847039: login works when krb5_kpasswd is unresolvable (kpasswd not needed for auth). - high UID: BZ 798655: auth and logs stay clean with a setuid(-2) helper process running. - password change: GH 677: SSH passwd with chpass_provider=krb5 logs initial auth in krb5_child.log. Signed-off-by: Madhuri Upadhye <mupadhye@redhat.com>
madhuriupadhye
force-pushed
the
SSSD-sssd-backport-pr8612-to-sssd-2-12
branch
from
c5f5092 to
a6e6080
Compare
aplopez
approved these changes
Apr 30, 2026
Contributor
aplopez
left a comment
aplopez
left a comment
There was a problem hiding this comment.
LGTM
I think these new changes need to be ported to the other versions, in particular the -2.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of PR#8612 Tests: LDAP+KRB5 krb_misc tests to branch sssd-2-12, created by @madhuriupadhye.
Please make sure this backport is correct.
Note
The commits were cherry-picked without conflicts.
You can push changes to this pull request
Original commits
20eeac6 - Tests: LDAP+KRB5 krb_misc tests
Backported commits
Original Pull Request Body
Ported following test case: