removing unstable topologies from memecache tests#8624
Merged
danlavu merged 1 commit intoSSSD:masterfrom Apr 22, 2026
Merged
Conversation
danlavu
added
Waiting for review
Tests
Trivial
danlavu
force-pushed
the
tests-memcache-topologies
branch
from
99e742f to
6e3a525
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request simplifies the test configuration in src/tests/system/tests/test_memcache.py by replacing the combination of KnownTopologyGroup.AnyProvider and KnownTopology.LDAP with a direct KnownTopology.LDAP marker across several test functions. Additionally, it removes the unused KnownTopologyGroup import and includes minor docstring adjustments. I have no feedback to provide.
danlavu
force-pushed
the
tests-memcache-topologies
branch
from
6e3a525 to
f323455
Compare
spoore1
approved these changes
Apr 21, 2026
Contributor
spoore1
left a comment
spoore1
left a comment
There was a problem hiding this comment.
LGTM. Test failures for Fedora 43 (test_ipa) and 45 (test_sssctl) were not related to these trivial changes (test_memcache).
Reviewed-by: Scott Poore <spoore@redhat.com>
Contributor
sssd-bot
force-pushed
the
tests-memcache-topologies
branch
from
f323455 to
3ddf3e8
Compare
This was referenced Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.