Skip to content

[autobackport: sssd-2-12] removing unstable topologies from memecache tests#8626

Merged
danlavu merged 1 commit intoSSSD:sssd-2-12from
sssd-bot:SSSD-sssd-backport-pr8624-to-sssd-2-12
Apr 23, 2026
Merged

[autobackport: sssd-2-12] removing unstable topologies from memecache tests#8626
danlavu merged 1 commit intoSSSD:sssd-2-12from
sssd-bot:SSSD-sssd-backport-pr8624-to-sssd-2-12

Conversation

@sssd-bot
Copy link
Copy Markdown
Contributor

This is an automatic backport of PR#8624 removing unstable topologies from memecache tests to branch sssd-2-12, created by @danlavu.

Please make sure this backport is correct.

Note

The commits were cherry-picked without conflicts.

You can push changes to this pull request

git remote add sssd-bot git@github.com:sssd-bot/sssd.git
git fetch sssd-bot refs/heads/SSSD-sssd-backport-pr8624-to-sssd-2-12
git checkout SSSD-sssd-backport-pr8624-to-sssd-2-12
git push sssd-bot SSSD-sssd-backport-pr8624-to-sssd-2-12 --force

Original commits
6726f5a - removing unstable topologies from memecache tests

Backported commits

  • 7ed262d - removing unstable topologies from memecache tests

Original Pull Request Body

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies the test topology configuration in src/tests/system/tests/test_memcache.py by replacing the combination of KnownTopologyGroup.AnyProvider and preferred_topology marks with a direct topology mark for KnownTopology.LDAP across multiple test functions. Additionally, the unused KnownTopologyGroup import has been removed. I have no feedback to provide.

@danlavu danlavu added Trivial A single reviewer is sufficient to review the Pull Request no-backport This should go to target branch only. Waiting for review Tests labels Apr 22, 2026
Copy link
Copy Markdown
Contributor

@spoore1 spoore1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. rpm build failure is known issue in sssd-2-12 relating to ini_config.

Reviewed-by: Scott Poore <spoore@redhat.com>
(cherry picked from commit 6726f5a)
@sssd-bot
Copy link
Copy Markdown
Contributor Author

The pull request was accepted by @spoore1 with the following PR CI status:


🟢 rpm-build:centos-stream-10-x86_64:upstream (success)
🟢 rpm-build:fedora-42-x86_64:upstream (success)
🟢 rpm-build:fedora-43-x86_64:upstream (success)
🟢 rpm-build:fedora-44-x86_64:upstream (success)
🔴 rpm-build:fedora-rawhide-x86_64:upstream (failure)


There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging.

@sssd-bot sssd-bot force-pushed the SSSD-sssd-backport-pr8624-to-sssd-2-12 branch from 7ed262d to e669177 Compare April 22, 2026 20:19
@danlavu danlavu merged commit c1b1155 into SSSD:sssd-2-12 Apr 23, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Accepted no-backport This should go to target branch only. Tests Trivial A single reviewer is sufficient to review the Pull Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants